From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/xe: Set TTM device beneficial_order to 9 (2M)
Date: Tue, 05 May 2026 10:13:41 +1000 [thread overview]
Message-ID: <review-patch5-20260430182335.2132382-6-matthew.brost@intel.com> (raw)
In-Reply-To: <20260430182335.2132382-6-matthew.brost@intel.com>
Patch Review
**Overall:** Simple one-liner that sets the beneficial order for Xe's TTM device to order 9 (2M pages).
```c
- xe->drm.vma_offset_manager, 0);
+ xe->drm.vma_offset_manager,
+ TTM_ALLOCATION_POOL_BENEFICIAL_ORDER(get_order(SZ_2M)));
```
**Observations:**
- `get_order(SZ_2M)` = `get_order(2*1024*1024)` = 9 on systems with 4K pages. On 16K page systems (some ARM), this would be different. Using `get_order()` is correct and portable.
- `TTM_ALLOCATION_POOL_BENEFICIAL_ORDER` is a simple mask `((n) & 0xff)` so this is just `9 & 0xff = 9`.
- Already has Reviewed-by from Andi Shyti.
- Clean and correct.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-05 0:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 18:23 [PATCH v3 0/6] mm, drm/ttm, drm/xe: Avoid reclaim/eviction loops under fragmentation Matthew Brost
2026-04-30 18:23 ` [PATCH v3 1/6] mm: Wire up order in shrink_control Matthew Brost
2026-05-05 0:13 ` Claude review: " Claude Code Review Bot
2026-04-30 18:23 ` [PATCH v3 2/6] mm: Introduce zone_maybe_fragmented_in_shrinker() Matthew Brost
2026-05-05 0:13 ` Claude review: " Claude Code Review Bot
2026-04-30 18:23 ` [PATCH v3 3/6] drm/ttm: Issue direct reclaim at beneficial_order Matthew Brost
2026-05-05 0:13 ` Claude review: " Claude Code Review Bot
2026-04-30 18:23 ` [PATCH v3 4/6] drm/ttm: Introduce ttm_bo_shrink_kswap_maybe_fragmented() Matthew Brost
2026-05-05 0:13 ` Claude review: " Claude Code Review Bot
2026-04-30 18:23 ` [PATCH v3 5/6] drm/xe: Set TTM device beneficial_order to 9 (2M) Matthew Brost
2026-05-05 0:13 ` Claude Code Review Bot [this message]
2026-04-30 18:23 ` [PATCH v3 6/6] drm/xe: Avoid shrinker reclaim from kswapd under fragmentation Matthew Brost
2026-05-05 0:13 ` Claude review: " Claude Code Review Bot
2026-05-05 0:13 ` Claude review: mm, drm/ttm, drm/xe: Avoid reclaim/eviction loops " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-30 19:18 [PATCH v4 0/6] " Matthew Brost
2026-04-30 19:18 ` [PATCH v4 5/6] drm/xe: Set TTM device beneficial_order to 9 (2M) Matthew Brost
2026-05-05 0:00 ` Claude review: " Claude Code Review Bot
2026-04-21 1:26 [PATCH 0/3] drm/ttm, drm/xe: Avoid reclaim/eviction loops under fragmentation Matthew Brost
2026-04-21 1:26 ` [PATCH 2/3] drm/xe: Set TTM device beneficial_order to 9 (2M) Matthew Brost
2026-04-22 23:01 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch5-20260430182335.2132382-6-matthew.brost@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox