From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel-edp: Add BOE NT140WHM-N4T, BOE NT140WHM-T05, BOE NV140FHM-N40
Date: Thu, 07 May 2026 13:22:15 +1000 [thread overview]
Message-ID: <review-patch2-20260506170607.10813-3-terry_hsiao@compal.corp-partner.google.com> (raw)
In-Reply-To: <20260506170607.10813-3-terry_hsiao@compal.corp-partner.google.com>
Patch Review
**Minor concern.** Three BOE panel entries added:
| Product ID | Panel Name | Delay |
|---|---|---|
| 0x090d | NT140WHM-N4T | delay_200_500_e50 |
| 0x0b85 | NT140WHM-T05 | delay_200_500_e50 |
| 0x0c6f | NV140FHM-N40 | delay_200_500_e50 |
- All product IDs verified against provided EDIDs.
- Sort order is correct for all three insertions.
**Note on delay choice:** All three use `delay_200_500_e50`, while some comparable BOE panels use longer enable delays — e.g., NT140WHM-N49 (0x08b2) uses `delay_200_500_e200`, NT140FHM-N47 (0x0b56) uses `delay_200_500_e80`. The NV140FHM-N40 in particular is a FHD panel similar to NT140FHM-N47. Using `e50` isn't wrong (other BOE panels like 0x09c3 and 0x0964 also use it), but the submitter should confirm these shorter enable delays were validated on actual hardware.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-07 3:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 17:06 [PATCH v1 0/4] drm/panel-edp: Add and update multiple AUO, BOE, CMN, and IVO panels Terry Hsiao
2026-05-06 17:06 ` [PATCH v1 1/4] drm/panel-edp: Add AUO B140XTN07.5, AUO B140HAK03.5, AUO B116XTN02.3, AUO B140XTK02.4, AUO B140HAN07.7 Terry Hsiao
2026-05-07 3:22 ` Claude review: " Claude Code Review Bot
2026-05-06 17:06 ` [PATCH v1 2/4] drm/panel-edp: Add BOE NT140WHM-N4T, BOE NT140WHM-T05, BOE NV140FHM-N40 Terry Hsiao
2026-05-07 3:22 ` Claude Code Review Bot [this message]
2026-05-06 17:06 ` [PATCH v1 3/4] drm/panel-edp: Add CMN N116BCN-EA1, CMN N140HCA-EEK, IVO M140NWFQ R5, IVO R140NWFW R0 Terry Hsiao
2026-05-07 3:22 ` Claude review: " Claude Code Review Bot
2026-05-06 17:06 ` [PATCH v1 4/4] drm/panel-edp: Modify panel name and delay for CMN 0x14d6 Terry Hsiao
2026-05-07 3:22 ` Claude review: " Claude Code Review Bot
2026-05-07 3:22 ` Claude review: drm/panel-edp: Add and update multiple AUO, BOE, CMN, and IVO panels Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260506170607.10813-3-terry_hsiao@compal.corp-partner.google.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox