From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel-edp: Modify panel name and delay for CMN 0x14d6
Date: Thu, 07 May 2026 13:22:16 +1000 [thread overview]
Message-ID: <review-patch4-20260506170607.10813-5-terry_hsiao@compal.corp-partner.google.com> (raw)
In-Reply-To: <20260506170607.10813-5-terry_hsiao@compal.corp-partner.google.com>
Patch Review
**Needs more justification.** This patch changes the existing CMN 0x14d6 entry:
```c
- EDP_PANEL_ENTRY('C', 'M', 'N', 0x14d6, &delay_200_500_e80_d50, "N140BGA-EA4"),
+ EDP_PANEL_ENTRY('C', 'M', 'N', 0x14d6, &delay_200_500_e80, "N140BGA-E54"),
```
**Name correction is validated:** The existing table already has "N140BGA-EA4" at product ID 0x142e (line 2064), confirming that 0x14d6 is a *different* panel and the original name was incorrect. The corrected name "N140BGA-E54" makes sense.
**Delay change needs explanation:** Changing from `delay_200_500_e80_d50` to `delay_200_500_e80` removes the 50ms disable delay. The commit message says "adjust its delay configuration" but doesn't explain *why* the disable delay was wrong or what testing confirmed the new value is safe. This is a behavioral change for existing users of this panel. Was the d50 causing a visible artifact on power-off? Was it measured against the panel datasheet? The commit message should include this rationale so maintainers and future readers understand the change isn't just cosmetic.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-07 3:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 17:06 [PATCH v1 0/4] drm/panel-edp: Add and update multiple AUO, BOE, CMN, and IVO panels Terry Hsiao
2026-05-06 17:06 ` [PATCH v1 1/4] drm/panel-edp: Add AUO B140XTN07.5, AUO B140HAK03.5, AUO B116XTN02.3, AUO B140XTK02.4, AUO B140HAN07.7 Terry Hsiao
2026-05-07 3:22 ` Claude review: " Claude Code Review Bot
2026-05-06 17:06 ` [PATCH v1 2/4] drm/panel-edp: Add BOE NT140WHM-N4T, BOE NT140WHM-T05, BOE NV140FHM-N40 Terry Hsiao
2026-05-07 3:22 ` Claude review: " Claude Code Review Bot
2026-05-06 17:06 ` [PATCH v1 3/4] drm/panel-edp: Add CMN N116BCN-EA1, CMN N140HCA-EEK, IVO M140NWFQ R5, IVO R140NWFW R0 Terry Hsiao
2026-05-07 3:22 ` Claude review: " Claude Code Review Bot
2026-05-06 17:06 ` [PATCH v1 4/4] drm/panel-edp: Modify panel name and delay for CMN 0x14d6 Terry Hsiao
2026-05-07 3:22 ` Claude Code Review Bot [this message]
2026-05-07 3:22 ` Claude review: drm/panel-edp: Add and update multiple AUO, BOE, CMN, and IVO panels Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260506170607.10813-5-terry_hsiao@compal.corp-partner.google.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox