public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: phy: qualcomm: hdmi-28lpm: provide dynamic configuration
Date: Sat, 16 May 2026 11:32:10 +1000	[thread overview]
Message-ID: <review-patch2-20260513-fd-hdmi-phy-v9-2-ca98c72f1f9f@oss.qualcomm.com> (raw)
In-Reply-To: <20260513-fd-hdmi-phy-v9-2-ca98c72f1f9f@oss.qualcomm.com>

Patch Review

This patch replaces the fixed frequency lookup tables (the old `freqtbl[]` array with hardcoded register values for 8 specific pixel clocks) with runtime-calculated PLL configuration. This is a significant improvement as it enables arbitrary pixel clocks within the VCO range.

The PLL math looks reasonable:
```c
dc_offset = vco_freq / int_ref_freq - 1;
tmp = vco_freq % int_ref_freq;
tmp *= 0x10000;
sdm_freq_seed = div_u64(tmp, int_ref_freq);
```

**XXX comments**: There are two `XXX` comments left in the code:
```c
/* XXX: 19.2 for qcs404 */
unsigned long parent_rate = 27000000;
```
and:
```c
/* XXX: 0xc3 instead of 0x33 for qcs404 */
lf_cfg1 = dc_offset >= 30 ? 0x33 : ...
```
These are fine as markers for future QCS404 work, but should be tracked.

**Kconfig typo**: Line 5030 in the overall mbox: `"HDMI PHY presend on 32-bit platforms"` should be `"present"`. (This was actually introduced in patch 1, but worth flagging.)

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  1:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13 18:14 [PATCH v9 0/5] drm/msm/hdmi & phy: use generic PHY framework Dmitry Baryshkov
2026-05-13 18:14 ` [PATCH v9 1/5] drm/msm/hdmi: switch to generic PHY subsystem Dmitry Baryshkov
2026-05-16  1:32   ` Claude review: " Claude Code Review Bot
2026-05-13 18:14 ` [PATCH v9 2/5] phy: qualcomm: hdmi-28lpm: provide dynamic configuration Dmitry Baryshkov
2026-05-16  1:32   ` Claude Code Review Bot [this message]
2026-05-13 18:14 ` [PATCH v9 3/5] phy: qcom: apq8064-sata: extract UNI PLL register defines Dmitry Baryshkov
2026-05-16  1:32   ` Claude review: " Claude Code Review Bot
2026-05-13 18:14 ` [PATCH v9 4/5] phy: qcom-uniphy: add more registers from display PHYs Dmitry Baryshkov
2026-05-16  1:32   ` Claude review: " Claude Code Review Bot
2026-05-13 18:14 ` [PATCH v9 5/5] phy: qualcomm: add MSM8974 HDMI PHY support Dmitry Baryshkov
2026-05-16  1:32   ` Claude review: " Claude Code Review Bot
2026-05-16  1:32 ` Claude review: drm/msm/hdmi & phy: use generic PHY framework Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260513-fd-hdmi-phy-v9-2-ca98c72f1f9f@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox