From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: bridge: Document Renesas R-Car V4H DSC bindings
Date: Sat, 16 May 2026 09:29:57 +1000 [thread overview]
Message-ID: <review-patch2-20260515-rcar-du-dsc-v3-2-164157820498@ideasonboard.com> (raw)
In-Reply-To: <20260515-rcar-du-dsc-v3-2-164157820498@ideasonboard.com>
Patch Review
The binding looks correct. Two minor observations:
1. The binding uses `unevaluatedProperties: false` at the top level. Since there is no `allOf` inheriting from another schema, `additionalProperties: false` would be the more conventional choice. Both work, but `additionalProperties` is the norm for standalone bindings (see most other files in the same directory).
2. The binding documents `interrupts` and `resets` as required properties, which is correct for completeness of the hardware description, even though the current driver (patch 3) doesn't use either. This is fine — bindings should describe the hardware, not the current driver capability.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-15 23:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 9:09 [PATCH v3 0/7] drm/rcar-du: Add support for DSI pipelines with DSC Tomi Valkeinen
2026-05-15 9:09 ` [PATCH v3 1/7] clk: renesas: r8a779g0: Add DSC clock Tomi Valkeinen
2026-05-15 23:29 ` Claude review: " Claude Code Review Bot
2026-05-15 9:09 ` [PATCH v3 2/7] dt-bindings: display: bridge: Document Renesas R-Car V4H DSC bindings Tomi Valkeinen
2026-05-15 23:29 ` Claude Code Review Bot [this message]
2026-05-15 9:09 ` [PATCH v3 3/7] drm/rcar-du: dsc: Add rudimentary Renesas R-Car V4H DSC driver Tomi Valkeinen
2026-05-15 23:29 ` Claude review: " Claude Code Review Bot
2026-05-15 9:09 ` [PATCH v3 4/7] drm/rcar-du: dsi: Support DSC in the pipeline Tomi Valkeinen
2026-05-15 23:29 ` Claude review: " Claude Code Review Bot
2026-05-15 9:09 ` [PATCH v3 5/7] arm64: dts: renesas: r8a779g0: Add DSC Tomi Valkeinen
2026-05-15 23:29 ` Claude review: " Claude Code Review Bot
2026-05-15 9:09 ` [PATCH v3 6/7] arm64: dts: renesas: sparrow-hawk: Enable DisplayPort by adding DSC Tomi Valkeinen
2026-05-15 23:29 ` Claude review: " Claude Code Review Bot
2026-05-15 9:09 ` [PATCH v3 7/7] arm64: dts: renesas: white-hawk: Add second mini-DP output support Tomi Valkeinen
2026-05-15 23:29 ` Claude review: " Claude Code Review Bot
2026-05-15 23:29 ` Claude review: drm/rcar-du: Add support for DSI pipelines with DSC Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-15 7:56 [PATCH v2 0/5] " Tomi Valkeinen
2026-05-15 7:56 ` [PATCH v2 2/5] dt-bindings: display: bridge: Document Renesas R-Car V4H DSC bindings Tomi Valkeinen
2026-05-15 23:46 ` Claude review: " Claude Code Review Bot
2026-05-14 12:24 [PATCH 0/5] drm/rcar-du: Add support for DSI pipelines with DSC Tomi Valkeinen
2026-05-14 12:24 ` [PATCH 2/5] dt-bindings: display: bridge: Document Renesas R-Car V4H DSC bindings Tomi Valkeinen
2026-05-16 0:53 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260515-rcar-du-dsc-v3-2-164157820498@ideasonboard.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox