public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/a6xx: Enable CLX feature on A840
Date: Sat, 16 May 2026 08:47:13 +1000	[thread overview]
Message-ID: <review-patch2-20260516-a8xx-clx-support-v1-2-62508bf651ac@oss.qualcomm.com> (raw)
In-Reply-To: <20260516-a8xx-clx-support-v1-2-62508bf651ac@oss.qualcomm.com>

Patch Review

**Issue: `a840_limits_tbl` should be `static const`.**

```c
struct a6xx_hfi_limits_tbl a840_limits_tbl[] = {
```

This is missing both `static` and `const`. All other comparable catalog arrays in this file (e.g., `a840_dyn_pwrup_reglist_regs[]`) are `static const`. This table is only referenced through the `DECLARE_ADRENO_LIMITS_TABLE(a840_limits)` macro and should be:
```c
static const struct a6xx_hfi_limits_tbl a840_limits_tbl[] = {
```

Without `static`, the symbol is externally visible (unnecessary namespace pollution). Without `const`, the data goes into the writable data section instead of rodata. Also, as noted above, the `DECLARE_ADRENO_LIMITS_TABLE` macro assigns `name ## _tbl` to a member in a `static const` struct, so having the underlying array be non-const creates a type inconsistency.

**Data tables look reasonable.** Four limits entries (IFF for GX, IFF for MX, PCLX for GX, PCLX for MX) with the MX PCLX entry disabled (`.enable = 0`) — this is a sensible per-domain configuration. The CLX domain table has two domains (GX and MXG) with different current budgets (100 vs 50), which matches the asymmetric power characteristics.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-15 22:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 20:07 [PATCH 0/3] drm/msm/adreno: Support for CLX feature on A8xx Akhil P Oommen
2026-05-15 20:07 ` [PATCH 1/3] drm/msm/a6xx: Add HFI support for CLX feature Akhil P Oommen
2026-05-15 22:47   ` Claude review: " Claude Code Review Bot
2026-05-15 20:07 ` [PATCH 2/3] drm/msm/a6xx: Enable CLX feature on A840 Akhil P Oommen
2026-05-15 22:47   ` Claude Code Review Bot [this message]
2026-05-15 20:07 ` [PATCH 3/3] drm/msm/a8xx: Enable CLX feature on Adreno X2-85 Akhil P Oommen
2026-05-15 22:47   ` Claude review: " Claude Code Review Bot
2026-05-15 22:47 ` Claude review: drm/msm/adreno: Support for CLX feature on A8xx Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260516-a8xx-clx-support-v1-2-62508bf651ac@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox