public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/a8xx: Enable CLX feature on Adreno X2-85
Date: Sat, 16 May 2026 08:47:14 +1000	[thread overview]
Message-ID: <review-patch3-20260516-a8xx-clx-support-v1-3-62508bf651ac@oss.qualcomm.com> (raw)
In-Reply-To: <20260516-a8xx-clx-support-v1-3-62508bf651ac@oss.qualcomm.com>

Patch Review

**Same `static const` issue as patch 2:**

```c
struct a6xx_hfi_limits_tbl x285_limits_tbl[] = {
```

Should be `static const struct a6xx_hfi_limits_tbl x285_limits_tbl[]`.

**Data is structurally identical to A840 with different tuning values.** The X2-85 has higher current limits (18000 vs 6000 for IFF GX, 66000 vs 30000 for PCLX GX) and different SID values, and both CLX domains have `curr_budget = 100` (vs 100/50 for A840), consistent with a more power-hungry GPU.

**Minor observation:** Patches 2 and 3 place the X2-85 data tables *before* the A840 data tables in the source file (line 1799 vs 2108), which is fine since order doesn't matter for catalog entries, but it does mean the series adds X2-85 tables earlier in the file than A840 tables despite A840 being enabled first in the series. Not a problem, just mildly surprising when reading the diff.

---

**Summary of requested changes:**

1. **Patch 1**: Make `struct a6xx_limits_tbl::tbl` a `const` pointer: `const struct a6xx_hfi_limits_tbl *tbl`
2. **Patches 2 & 3**: Add `static const` to `a840_limits_tbl[]` and `x285_limits_tbl[]`

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-15 22:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 20:07 [PATCH 0/3] drm/msm/adreno: Support for CLX feature on A8xx Akhil P Oommen
2026-05-15 20:07 ` [PATCH 1/3] drm/msm/a6xx: Add HFI support for CLX feature Akhil P Oommen
2026-05-15 22:47   ` Claude review: " Claude Code Review Bot
2026-05-15 20:07 ` [PATCH 2/3] drm/msm/a6xx: Enable CLX feature on A840 Akhil P Oommen
2026-05-15 22:47   ` Claude review: " Claude Code Review Bot
2026-05-15 20:07 ` [PATCH 3/3] drm/msm/a8xx: Enable CLX feature on Adreno X2-85 Akhil P Oommen
2026-05-15 22:47   ` Claude Code Review Bot [this message]
2026-05-15 22:47 ` Claude review: drm/msm/adreno: Support for CLX feature on A8xx Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260516-a8xx-clx-support-v1-3-62508bf651ac@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox