public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/radeon: fix internal display on iMac11, 1 (RV770/DCE3.1)
Date: Mon, 18 May 2026 16:57:04 +1000	[thread overview]
Message-ID: <review-patch2-20260516092420.3579-2-gilles.risch@gmail.com> (raw)
In-Reply-To: <20260516092420.3579-2-gilles.risch@gmail.com>

Patch Review

**Correctness: Looks correct.** The new macro is well-placed and the logic follows the existing DCE versioning scheme.

**Issue 1 — Missing `Fixes:` tag:** The commit message references "Fixes freedesktop issue 164" in prose, but does not include a kernel-style `Fixes:` tag pointing to the commit that introduced the regression (or the original DCE3.2 logic that omitted RV770). If this is a fix for existing behavior, it should have:
```
Fixes: <sha1> ("drm/radeon: ...")
Cc: stable@vger.kernel.org
```
If there's no single commit to blame (the logic was always wrong), a `Cc: stable` is still appropriate since this is a hardware enablement fix for a longstanding bug.

**Issue 2 — PLL flag changes affect all RV770 systems, not just iMac:**

```c
-		if (ASIC_IS_DCE32(rdev) && mode->clock > 200000)
+		if (ASIC_IS_DCE31(rdev) && mode->clock > 200000)
```

This change means *every* RV770-based system (not just the iMac11,1) will now get `RADEON_PLL_PREFER_HIGH_FB_DIV` for high clocks and `RADEON_PLL_USE_FRAC_FB_DIV` for clocks > 165000. While this is likely the correct behavior for DCE3.1 hardware in general, the commit message frames this purely as an iMac fix. The author should confirm this is intentional for all RV770 cards, or if it should be gated behind a DMI check. Given that line 588 already has `if (rdev->family < CHIP_RV770)` as a boundary, this is likely fine — but it should be stated explicitly in the commit message.

**Issue 3 — Audit of remaining `ASIC_IS_DCE32` call sites:** There are additional `ASIC_IS_DCE32()` users in `r600.c` (interrupt handling, HDMI, HPD) and `radeon_audio.c`. The author should confirm these do not also need the DCE3.1 treatment. If they are truly DCE3.2-specific features, the commit message should note this.

**Minor — Subject line wrapping:** The subject line appears wrapped across multiple header lines in the mbox (`Subject: [PATCH v2] drm/radeon: fix internal display on iMac11,\n 1 (RV770/DCE3.1)`). This may be an email client artifact, but the author should verify `git log --oneline` shows it correctly.

---

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-05-18  6:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-10 18:54 [PATCH] The Apple iMac11, 1 (late 2009) has an integrated ATI Mobility Radeon HD 4850. This machine suffers from a similar problem as the iMac10, 1 (late 2009) and the iMac11, 2 (mid 2010). This small patch fixes the issue on this machine Gilles Risch
2026-05-16  5:26 ` Claude review: " Claude Code Review Bot
2026-05-16  5:26 ` Claude Code Review Bot
2026-05-16  9:24 ` [PATCH v2] drm/radeon: fix internal display on iMac11, 1 (RV770/DCE3.1) Gilles Risch
2026-05-16 18:09   ` Lukas Wunner
2026-05-17 13:53     ` Gilles Risch
2026-05-17 14:05       ` Lukas Wunner
2026-05-18  6:36     ` Claude review: " Claude Code Review Bot
2026-05-16 18:52   ` [PATCH] drm/radeon: fix eDP resume from suspend on iMac11, 1 / DCE3.1 systems Gilles Risch
2026-05-17  3:28     ` kernel test robot
2026-05-17  5:12     ` kernel test robot
2026-05-18  6:57   ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260516092420.3579-2-gilles.risch@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox