From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: The Apple iMac11, 1 (late 2009) has an integrated ATI Mobility Radeon HD 4850. This machine suffers from a similar problem as the iMac10, 1 (late 2009) and the iMac11, 2 (mid 2010). This small patch fixes the issue on this machine.
Date: Sat, 16 May 2026 15:26:36 +1000 [thread overview]
Message-ID: <review-overall-20260510185426.4264-1-gilles.risch@gmail.com> (raw)
In-Reply-To: <20260510185426.4264-1-gilles.risch@gmail.com>
Overall Series Review
Subject: The Apple iMac11, 1 (late 2009) has an integrated ATI Mobility Radeon HD 4850. This machine suffers from a similar problem as the iMac10, 1 (late 2009) and the iMac11, 2 (mid 2010). This small patch fixes the issue on this machine.
Author: Gilles Risch <gilles.risch@gmail.com>
Patches: 1
Reviewed: 2026-05-16T15:26:36.767296
---
This is a single patch fixing display issues on the Apple iMac11,1 (late 2009, ATI Mobility Radeon HD 4850 / RV770). The core problem being fixed is real: the RV770 chip is DCE 3.2 hardware, but the existing `ASIC_IS_DCE32` macro (`>= CHIP_RV730`) accidentally excludes RV770 because `CHIP_RV770` precedes `CHIP_RV730` in the `radeon_family` enum. This causes PLL misconfiguration and wrong encoder selection on RV770-based Apple machines.
However, the patch has **significant issues** with its approach, naming, commit message formatting, and missing sign-off. It should not be applied in its current form.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 5:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 18:54 [PATCH] The Apple iMac11, 1 (late 2009) has an integrated ATI Mobility Radeon HD 4850. This machine suffers from a similar problem as the iMac10, 1 (late 2009) and the iMac11, 2 (mid 2010). This small patch fixes the issue on this machine Gilles Risch
2026-05-16 5:26 ` Claude Code Review Bot [this message]
2026-05-16 5:26 ` Claude review: " Claude Code Review Bot
2026-05-16 9:24 ` [PATCH v2] drm/radeon: fix internal display on iMac11, 1 (RV770/DCE3.1) Gilles Risch
2026-05-16 18:09 ` Lukas Wunner
2026-05-17 13:53 ` Gilles Risch
2026-05-17 14:05 ` Lukas Wunner
2026-05-18 6:36 ` Claude review: " Claude Code Review Bot
2026-05-16 18:52 ` [PATCH] drm/radeon: fix eDP resume from suspend on iMac11, 1 / DCE3.1 systems Gilles Risch
2026-05-17 3:28 ` kernel test robot
2026-05-17 5:12 ` kernel test robot
2026-05-18 6:57 ` Claude review: drm/radeon: fix internal display on iMac11, 1 (RV770/DCE3.1) Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-10 19:05 [PATCH] The Apple iMac11, 1 (late 2009) has an integrated ATI Mobility Radeon HD 4850. This machine suffers from a similar problem as the iMac10, 1 (late 2009) and the iMac11, 2 (mid 2010). This small patch fixes the issue on this machine Gilles Risch
2026-05-16 5:30 ` Claude review: " Claude Code Review Bot
2026-05-16 5:30 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260510185426.4264-1-gilles.risch@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox