From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: misc: fastrpc: Replace hardcoded ctxid mask with GENMASK
Date: Mon, 25 May 2026 22:12:29 +1000 [thread overview]
Message-ID: <review-patch2-20260520065047.3415790-3-ekansh.gupta@oss.qualcomm.com> (raw)
In-Reply-To: <20260520065047.3415790-3-ekansh.gupta@oss.qualcomm.com>
Patch Review
**Overall: Looks good.** Clean mechanical conversion.
The patch adds `#include <linux/bitops.h>` (though `<linux/bitfield.h>` would be more precise for `FIELD_PREP`/`FIELD_GET` — but `bitops.h` does pull in what's needed via `bits.h` which was already included).
Conversions are correct:
- `ctx->ctxid >> 4` → `FIELD_GET(FASTRPC_CTXID_MASK, ctx->ctxid)` — correct, GENMASK(11,4) with FIELD_GET extracts bits [11:4] shifted down.
- `ret << 4` → `FIELD_PREP(FASTRPC_CTXID_MASK, ret)` — correct.
- `(rsp->ctx & FASTRPC_CTXID_MASK) >> 4` → `FIELD_GET(FASTRPC_CTXID_MASK, rsp->ctx)` — correct.
**Minor nit:** The added include is `linux/bitops.h` but `FIELD_PREP`/`FIELD_GET` are from `linux/bitfield.h`. This likely works because of transitive includes, but `linux/bitfield.h` would be the canonical include for these macros.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 12:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 6:50 [PATCH v11 0/4] misc: fastrpc: Add polling mode support Ekansh Gupta
2026-05-20 6:50 ` [PATCH v11 1/4] misc: fastrpc: Move fdlist to invoke context structure Ekansh Gupta
2026-05-25 12:12 ` Claude review: " Claude Code Review Bot
2026-05-20 6:50 ` [PATCH v11 2/4] misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Ekansh Gupta
2026-05-25 12:12 ` Claude Code Review Bot [this message]
2026-05-20 6:50 ` [PATCH v11 3/4] misc: fastrpc: Expand context ID mask for DSP polling mode support Ekansh Gupta
2026-05-25 12:12 ` Claude review: " Claude Code Review Bot
2026-05-20 6:50 ` [PATCH v11 4/4] misc: fastrpc: Add polling mode support for fastRPC driver Ekansh Gupta
2026-05-20 13:36 ` Dmitry Baryshkov
2026-05-21 4:06 ` Ekansh Gupta
2026-05-25 12:12 ` Claude review: " Claude Code Review Bot
2026-05-25 12:12 ` Claude review: misc: fastrpc: Add polling mode support Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-21 5:45 [PATCH v12 0/4] " Ekansh Gupta
2026-05-21 5:45 ` [PATCH v12 2/4] misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Ekansh Gupta
2026-05-25 10:54 ` Claude review: " Claude Code Review Bot
2026-04-22 9:24 [PATCH v9 0/4] misc: fastrpc: Add polling mode support Ekansh Gupta
2026-04-22 9:24 ` [PATCH v9 2/4] misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Ekansh Gupta
2026-04-22 21:50 ` Claude review: " Claude Code Review Bot
2026-02-15 18:21 [PATCH v6 0/4] misc: fastrpc: Add polling mode support Ekansh Gupta
2026-02-15 18:21 ` [PATCH v6 2/4] misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Ekansh Gupta
2026-02-15 22:26 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260520065047.3415790-3-ekansh.gupta@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox