From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/xe/vm: Add srcid to xe_vm_get_property_ioctl fault report
Date: Thu, 04 Jun 2026 11:40:33 +1000 [thread overview]
Message-ID: <review-patch2-20260603150828.3751112-3-jonathan.cavitt@intel.com> (raw)
In-Reply-To: <20260603150828.3751112-3-jonathan.cavitt@intel.com>
Patch Review
**UAPI change:** The `__u8 pad` in `struct xe_vm_fault` is renamed to `__u8 srcid`. Since `pad` was MBZ and occupied the same offset, this is ABI-compatible — old userspace that set pad=0 will just read srcid=0 (or whatever value is there), and old kernels receiving new userspace won't break because the pad check was on the `drm_xe_vm_get_property` struct, not on the `xe_vm_fault` struct itself.
Looking at `xe_vm.c:4200-4202`, the pad check is on `args->pad` (the `drm_xe_vm_get_property` struct's pad, not `xe_vm_fault`'s pad), so this is indeed unaffected — the cover letter's "Readd pad check" note correctly identifies that the `drm_xe_vm_get_property.pad` check should remain.
**Nit:** `xe_to_user_srcid()` is a trivial identity function:
```c
static u8 xe_to_user_srcid(u8 srcid)
{
return srcid;
}
```
This follows the pattern of `xe_to_user_fault_type()` and `xe_to_user_fault_level()` which are also identity functions. I understand these exist as placeholders for potential future remapping (similar to the XXX comment about enum matching in `xe_guc_pagefault.c:74-76`), so this is consistent with the codebase style.
The `xe_vm_fault_entry` struct addition and the `xe_vm_add_fault_entry_pf` plumbing are both correct and straightforward.
No blocking issues with this patch.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 1:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 15:08 [PATCH v2 0/2] drm/xe/pagefault: Add SRCID to pagefault reporting Jonathan Cavitt
2026-06-03 15:08 ` [PATCH v2 1/2] drm/xe/pagefault: Add SRCID to pagefault struct Jonathan Cavitt
2026-06-04 1:40 ` Claude review: " Claude Code Review Bot
2026-06-03 15:08 ` [PATCH v2 2/2] drm/xe/vm: Add srcid to xe_vm_get_property_ioctl fault report Jonathan Cavitt
2026-06-04 1:40 ` Claude Code Review Bot [this message]
2026-06-04 1:40 ` Claude review: drm/xe/pagefault: Add SRCID to pagefault reporting Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-26 21:44 [PATCH 0/2] " Jonathan Cavitt
2026-05-26 21:44 ` [PATCH 2/2] drm/xe/vm: Add srcid to xe_vm_get_property_ioctl fault report Jonathan Cavitt
2026-05-27 4:00 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260603150828.3751112-3-jonathan.cavitt@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox