From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/xe/pagefault: Add SRCID to pagefault reporting
Date: Thu, 04 Jun 2026 11:40:32 +1000 [thread overview]
Message-ID: <review-overall-20260603150828.3751112-1-jonathan.cavitt@intel.com> (raw)
In-Reply-To: <20260603150828.3751112-1-jonathan.cavitt@intel.com>
Overall Series Review
Subject: drm/xe/pagefault: Add SRCID to pagefault reporting
Author: Jonathan Cavitt <jonathan.cavitt@intel.com>
Patches: 3
Reviewed: 2026-06-04T11:40:32.542120
---
This is a clean, small 2-patch series that adds the SRCID (source ID of the faulting hardware unit) to the xe pagefault reporting path. The data flows correctly from the GuC G2H message through the internal pagefault struct, into the per-VM fault entry, and out to userspace via the `xe_vm_get_property_ioctl`. The UAPI change reuses the existing `pad` byte in `struct xe_vm_fault`, which is correct since userspace was already required to pass it as zero (MBZ).
The series is straightforward and the implementation is consistent with the existing patterns for the other fault fields (access_type, fault_type, fault_level). One minor concern and one nit below.
**Verdict: Looks good with minor comments.**
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 1:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 15:08 [PATCH v2 0/2] drm/xe/pagefault: Add SRCID to pagefault reporting Jonathan Cavitt
2026-06-03 15:08 ` [PATCH v2 1/2] drm/xe/pagefault: Add SRCID to pagefault struct Jonathan Cavitt
2026-06-04 1:40 ` Claude review: " Claude Code Review Bot
2026-06-03 15:08 ` [PATCH v2 2/2] drm/xe/vm: Add srcid to xe_vm_get_property_ioctl fault report Jonathan Cavitt
2026-06-04 1:40 ` Claude review: " Claude Code Review Bot
2026-06-04 1:40 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-26 21:44 [PATCH 0/2] drm/xe/pagefault: Add SRCID to pagefault reporting Jonathan Cavitt
2026-05-27 4:00 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260603150828.3751112-1-jonathan.cavitt@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox