Claude review: Re: [PATCH v2 2/4] dt-bindings: npu: rockchip,rk3588-rknn-core: Add RK3568 support

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**1. Missing `$ref` key — YAML syntax error (critical)**

```yaml
  rockchip,pmu:
    : /schemas/types.yaml#/definitions/phandle
```

The second line is `: /schemas/types.yaml#/definitions/phandle` with no key. This should be:

```yaml
  rockchip,pmu:
    $ref: /schemas/types.yaml#/definitions/phandle
```

The `$ref` key appears to have been stripped (possibly by the email toolchain mangling `$`). This will cause `dt_binding_check` to fail. This is a must-fix.

**2. `rockchip,pmu` not conditionally required for RK3568**

The commit message says the phandle is "Required on RK3568" and the driver will fail at probe without it (`syscon_regmap_lookup_by_phandle` returns an error). But the binding doesn't add a conditional `required` block:

```yaml
if:
  properties:
    compatible:
      contains:
        const: rockchip,rk3568-rknn-core
then:
  required:
    - rockchip,pmu
```

Without this, `dtbs_check` won't catch a missing `rockchip,pmu` on RK3568 boards.

**3. The if/then for `sram-supply` looks correct**

Making `sram-supply` conditional on RK3588-only is the right approach.

---

---
Generated by Claude Code Patch Reviewer