public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: rockchip: rk3568-rock-3b: Enable NPU
Date: Thu, 04 Jun 2026 16:18:12 +1000	[thread overview]
Message-ID: <review-patch4-20260529155824.3099831-5-midgy971@gmail.com> (raw)
In-Reply-To: <20260529155824.3099831-5-midgy971@gmail.com>

Patch Review

This patch is clean and minimal:

```dts
&rknn_core_0 {
	npu-supply = <&vdd_npu>;
	status = "okay";
};

&rknn_mmu_0 {
	status = "okay";
};
```

No issues. The `vdd_npu` regulator is referenced from the existing board file. The pattern of enabling both the NPU core and its IOMMU is correct.

---

**Summary of must-fix items:**
1. **Patch 2**: Fix the missing `$ref` in the `rockchip,pmu` property definition
2. **Patch 1**: Check `clk_set_rate()` return values in `rk3568_noc_init()`
3. **Patch 1**: Fix the incomplete error cleanup path after `noc_init` failure
4. **Patch 3**: Move NPU nodes to the correct address-sorted position

**Items worth discussing:**
- Runtime PM / system suspend re-initialization of the NOC bus
- Whether `rockchip,pmu` should be conditionally required in the binding
- The fragility of the two-step PVTPLL workaround

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-06-04  6:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-29 15:58 [PATCH v2 0/4] accel: rocket: Add RK3568 NPU support MidG971
2026-05-29 15:58 ` [PATCH v2 1/4] accel: rocket: Add support for Rockchip RK3568 MidG971
2026-05-29 18:19   ` Heiko Stuebner
2026-06-04  6:18     ` Claude review: " Claude Code Review Bot
2026-05-29 15:58 ` [PATCH v2 2/4] dt-bindings: npu: rockchip, rk3588-rknn-core: Add RK3568 support MidG971
2026-05-29 16:18   ` [PATCH v2 2/4] dt-bindings: npu: rockchip,rk3588-rknn-core: " Krzysztof Kozlowski
2026-06-04  6:18     ` Claude review: " Claude Code Review Bot
2026-05-29 15:58 ` [PATCH v2 3/4] arm64: dts: rockchip: rk356x: Add NPU and its IOMMU MidG971
2026-06-04  6:18   ` Claude review: " Claude Code Review Bot
2026-05-29 15:58 ` [PATCH v2 4/4] arm64: dts: rockchip: rk3568-rock-3b: Enable NPU MidG971
2026-06-04  6:18   ` Claude Code Review Bot [this message]
2026-05-29 16:17 ` [PATCH v2 0/4] accel: rocket: Add RK3568 NPU support Krzysztof Kozlowski
2026-06-04  6:18   ` Claude review: " Claude Code Review Bot
2026-05-29 18:04 ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260529155824.3099831-5-midgy971@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox