public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/i915/display: Panel Replay BW optimization for DP2.0 tunneling
Date: Tue, 31 Mar 2026 17:12:02 +1000	[thread overview]
Message-ID: <review-patch3-20260330133620.3750559-4-animesh.manna@intel.com> (raw)
In-Reply-To: <20260330133620.3750559-4-animesh.manna@intel.com>

Patch Review

This is the main functional patch. The `intel_psr_allow_pr_bw_optimization()` helper is clean and correctly checks: not eDP, BW alloc enabled, and PR optimization supported.

**Functional concern — deactivation path does not clear `TRANS_DP2_PR_TUNNELING_ENABLE`:**

The activation in `dg2_activate_panel_replay()` sets or clears `TRANS_DP2_PR_TUNNELING_ENABLE` correctly:
```c
	if (intel_psr_allow_pr_bw_optimization(intel_dp))
		dp2_ctl_set |= TRANS_DP2_PR_TUNNELING_ENABLE;
	else
		dp2_ctl_clear = TRANS_DP2_PR_TUNNELING_ENABLE;
```

But the deactivation at `intel_psr.c:2281` only clears `TRANS_DP2_PANEL_REPLAY_ENABLE`:
```c
	intel_de_rmw(display, TRANS_DP2_CTL(intel_dp->psr.transcoder),
		     TRANS_DP2_PANEL_REPLAY_ENABLE, 0);
```

This leaves `TRANS_DP2_PR_TUNNELING_ENABLE` set after Panel Replay is deactivated. This could cause the tunneling hardware to continue attempting BW optimization when PR is no longer active, which seems wrong. The deactivation should also clear `TRANS_DP2_PR_TUNNELING_ENABLE`:
```c
	intel_de_rmw(display, TRANS_DP2_CTL(intel_dp->psr.transcoder),
		     TRANS_DP2_PANEL_REPLAY_ENABLE | TRANS_DP2_PR_TUNNELING_ENABLE, 0);
```

Similarly, the `intel_psr_get_config()` readback at line 4290 only checks `TRANS_DP2_PANEL_REPLAY_ENABLE` — it may be worth reading back the tunneling bit as well for debug/state verification, though this is less critical.

**The register bit definition** (`REG_BIT(26)`) and placement is consistent with the existing definitions in `intel_display_regs.h`.

**Overall**, this is a well-structured series. The deactivation path issue should be fixed before merging.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-31  7:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-30 13:36 [PATCH v10 0/3] Panel Replay BW optimization Animesh Manna
2026-03-30 13:36 ` [PATCH v10 1/3] drm/display: Add drm helper to check pr optimization support Animesh Manna
2026-03-31  7:12   ` Claude review: " Claude Code Review Bot
2026-03-30 13:36 ` [PATCH v10 2/3] drm/i915/display: Add hook to check optimization support for Intel platforms Animesh Manna
2026-03-31  7:12   ` Claude review: " Claude Code Review Bot
2026-03-30 13:36 ` [PATCH v10 3/3] drm/i915/display: Panel Replay BW optimization for DP2.0 tunneling Animesh Manna
2026-03-31  7:12   ` Claude Code Review Bot [this message]
2026-03-31  7:12 ` Claude review: Panel Replay BW optimization Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-12  5:00 [PATCH v7 0/3] " Animesh Manna
2026-03-12  5:00 ` [PATCH v7 2/3] drm/i915/display: Panel Replay BW optimization for DP2.0 tunneling Animesh Manna
2026-03-13  4:30   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260330133620.3750559-4-animesh.manna@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox