public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/i915/display: Add hook to check optimization support for Intel platforms
Date: Tue, 31 Mar 2026 17:12:01 +1000	[thread overview]
Message-ID: <review-patch2-20260330133620.3750559-3-animesh.manna@intel.com> (raw)
In-Reply-To: <20260330133620.3750559-3-animesh.manna@intel.com>

Patch Review

Wraps the drm core function with a `DISPLAY_VER(display) < 35` guard.

**Kdoc mismatch:**
```
 * Returns %true if the BW allocation mode is supported on @intel_dp.
```
This is copy-pasted from the BW allocation function — it should say "PR BW optimization" instead of "BW allocation mode". The function name and description mention PR optimization correctly, but the Returns line is wrong.

**DISPLAY_VER check:** Gating on display version >= 35 is reasonable as this is a new platform feature. The stub for `CONFIG_DRM_DISPLAY_DP_TUNNEL=n` is correct.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-31  7:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-30 13:36 [PATCH v10 0/3] Panel Replay BW optimization Animesh Manna
2026-03-30 13:36 ` [PATCH v10 1/3] drm/display: Add drm helper to check pr optimization support Animesh Manna
2026-03-31  7:12   ` Claude review: " Claude Code Review Bot
2026-03-30 13:36 ` [PATCH v10 2/3] drm/i915/display: Add hook to check optimization support for Intel platforms Animesh Manna
2026-03-31  7:12   ` Claude Code Review Bot [this message]
2026-03-30 13:36 ` [PATCH v10 3/3] drm/i915/display: Panel Replay BW optimization for DP2.0 tunneling Animesh Manna
2026-03-31  7:12   ` Claude review: " Claude Code Review Bot
2026-03-31  7:12 ` Claude review: Panel Replay BW optimization Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260330133620.3750559-3-animesh.manna@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox