From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/doc/rfc: Remove i915_small_bar rfc.
Date: Thu, 23 Apr 2026 10:10:53 +1000 [thread overview]
Message-ID: <review-patch3-20260420083318.92038-9-dev@lankhorst.se> (raw)
In-Reply-To: <20260420083318.92038-9-dev@lankhorst.se>
Patch Review
**Reviewed-by worthy**: Yes.
The commit message references the specific commits that implemented the small BAR feature:
- `525e93f6317a ("drm/i915/uapi: add NEEDS_CPU_ACCESS hint")`
- `3f4309cbdc84 ("drm/i915/uapi: add probed_cpu_visible_size")`
The RFC described the `I915_GEM_CREATE_EXT_FLAG_NEEDS_CPU_ACCESS` flag and `probed_cpu_visible_size` attribute, both of which are now in the actual UAPI headers. The RFC has served its purpose.
The cautious "Probably done" in the commit message is honest — but looking at the RFC content, both key features it describes (the `NEEDS_CPU_ACCESS` flag and `probed_cpu_visible_size`) are referenced by the cited commits. This is done.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-23 0:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 8:33 [PATCH 0/4] drm/doc: Remove obsolete RFC docs related to i915 Maarten Lankhorst
2026-04-20 8:33 ` [PATCH 1/4] drm/doc/rfc: Remove i915_gem_lmem.rst Maarten Lankhorst
2026-04-23 0:10 ` Claude review: " Claude Code Review Bot
2026-04-20 8:33 ` [PATCH 2/4] drm/doc/rfc: Remove i915_vm_bind Maarten Lankhorst
2026-04-23 0:10 ` Claude review: " Claude Code Review Bot
2026-04-20 8:33 ` [PATCH 3/4] drm/doc/rfc: Remove i915_small_bar rfc Maarten Lankhorst
2026-04-23 0:10 ` Claude Code Review Bot [this message]
2026-04-20 8:33 ` [PATCH 4/4] drm/doc/rfc: Remove i915_scheduler item Maarten Lankhorst
2026-04-23 0:10 ` Claude review: " Claude Code Review Bot
2026-04-20 18:52 ` [PATCH 0/4] drm/doc: Remove obsolete RFC docs related to i915 Rodrigo Vivi
2026-04-23 0:10 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260420083318.92038-9-dev@lankhorst.se \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox