public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: device: generalize drvdata methods over ForLt
Date: Thu, 07 May 2026 13:02:04 +1000	[thread overview]
Message-ID: <review-patch3-20260506215113.851360-4-dakr@kernel.org> (raw)
In-Reply-To: <20260506215113.851360-4-dakr@kernel.org>

Patch Review

This is the critical patch that changes how driver private data is stored/retrieved.

In `set_drvdata`:
```rust
pub fn set_drvdata<'bound, F: ForLt>(
    &self,
    data: impl PinInit<F::Of<'bound>, Error>,
) -> Result {
    let data = KBox::pin_init(data, GFP_KERNEL)?;
    let ptr = KBox::into_raw(unsafe { Pin::into_inner_unchecked(data) });
    unsafe { bindings::dev_set_drvdata(self.as_raw(), ptr.cast()) };
    Ok(())
}
```

The key insight is that `F::Of<'bound>` and `F::Of<'static>` have identical layout (lifetimes are erased at runtime), so storing via raw pointer is sound. The `Pin::into_inner_unchecked` is safe because we're immediately converting to a raw pointer.

In `drvdata_unchecked`:
```rust
let pinned: Pin<&F::Of<'static>> =
    unsafe { Pin::<KBox<F::Of<'static>>>::borrow(ptr.cast()) };
unsafe { Pin::new_unchecked(F::cast_ref(pinned.get_ref())) }
```

This reconstructs a `Pin<&F::Of<'_>>` by first borrowing as `'static`, then shortening the lifetime via `ForLt::cast_ref`. The `Pin::new_unchecked` is justified because the data was pinned when stored and lifetime shortening doesn't affect pinning.

**Minor:** The transition from `ForeignOwnable`-based storage (`into_foreign`/`from_foreign`/`borrow`) to raw `KBox::into_raw`/`KBox::from_raw` changes the abstraction level. This is fine but means the `ForeignOwnable` import for `Pin<KBox<T>>` is likely now unused. The diff doesn't show whether that import is cleaned up.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-07  3:02 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06 21:50 [PATCH v2 00/25] rust: device: Higher-Ranked Lifetime Types for device drivers Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 01/25] rust: driver core: drop drvdata before devres release Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:50 ` [PATCH v2 02/25] rust: types: add `ForLt` trait for higher-ranked lifetime support Danilo Krummrich
2026-05-06 22:14   ` Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:50 ` [PATCH v2 03/25] rust: device: generalize drvdata methods over ForLt Danilo Krummrich
2026-05-07  3:02   ` Claude Code Review Bot [this message]
2026-05-06 21:50 ` [PATCH v2 04/25] rust: driver: make Adapter trait lifetime-parameterized Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:50 ` [PATCH v2 05/25] rust: pci: implement Sync for Device<Bound> Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 06/25] rust: platform: " Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 07/25] rust: auxiliary: " Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 08/25] rust: usb: " Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 09/25] rust: device: " Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:50 ` [PATCH v2 10/25] rust: pci: make Driver trait lifetime-parameterized Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:50 ` [PATCH v2 11/25] rust: platform: " Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 12/25] rust: auxiliary: " Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 13/25] rust: auxiliary: generalize Registration over ForLt Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 14/25] samples: rust: rust_driver_auxiliary: showcase lifetime-bound registration data Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 15/25] rust: usb: make Driver trait lifetime-parameterized Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 16/25] rust: i2c: " Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 17/25] rust: pci: make Bar lifetime-parameterized Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:50 ` [PATCH v2 18/25] rust: io: make IoMem and ExclusiveIoMem lifetime-parameterized Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:50 ` [PATCH v2 19/25] samples: rust: rust_driver_pci: use HRT lifetime for Bar Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:50 ` [PATCH v2 20/25] rust: driver-core: rename 'a lifetime to 'bound Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 21/25] gpu: nova-core: " Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 22/25] gpu: nova-core: use HRT lifetime for Bar Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:50 ` [PATCH v2 23/25] gpu: nova-core: unregister sysmem flush page from Drop Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:51 ` [PATCH v2 24/25] gpu: nova-core: replace ARef<Device> with &'bound Device in SysmemFlush Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:51 ` [PATCH v2 25/25] gpu: drm: tyr: use HRT lifetime for IoMem Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-07  3:02 ` Claude review: rust: device: Higher-Ranked Lifetime Types for device drivers Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-27 22:10 [PATCH 00/24] " Danilo Krummrich
2026-04-27 22:11 ` [PATCH 04/24] rust: device: generalize drvdata methods over ForLt Danilo Krummrich
2026-04-28  3:47   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260506215113.851360-4-dakr@kernel.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox