public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: pci: make Bar lifetime-parameterized
Date: Thu, 07 May 2026 13:02:05 +1000	[thread overview]
Message-ID: <review-patch17-20260506215113.851360-18-dakr@kernel.org> (raw)
In-Reply-To: <20260506215113.851360-18-dakr@kernel.org>

Patch Review

Key change: `Bar<SIZE>` becomes `Bar<'bound, SIZE>` holding `&'bound Device<Bound>` instead of `ARef<Device>`.

The `into_devres` method:
```rust
pub fn into_devres(self) -> Result<Devres<Bar<'static, SIZE>>> {
    let bar: Bar<'static, SIZE> = unsafe { core::mem::transmute(self) };
    let pdev = bar.pdev;
    Devres::new(pdev.as_ref(), bar)
}
```

The `transmute` from `Bar<'bound, SIZE>` to `Bar<'static, SIZE>` is sound because:
1. The only difference is the lifetime on the `&Device` reference, which doesn't affect layout
2. `Devres` manages the resource's actual lifetime via revocation, not Rust lifetimes
3. After `into_devres`, access goes through `Devres::access()` which checks device binding

**Minor note:** After the transmute, `bar.pdev` is a `&'static Device<Bound>`. This is used to call `Devres::new(pdev.as_ref(), bar)` which needs a `&Device<Bound>`. The `'static` reference is being used transiently here, which is fine since the `Devres` will manage the actual lifetime. But worth noting that this creates a brief `&'static` reference to the device, which is technically valid since the device does exist at this point.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-07  3:02 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06 21:50 [PATCH v2 00/25] rust: device: Higher-Ranked Lifetime Types for device drivers Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 01/25] rust: driver core: drop drvdata before devres release Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:50 ` [PATCH v2 02/25] rust: types: add `ForLt` trait for higher-ranked lifetime support Danilo Krummrich
2026-05-06 22:14   ` Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:50 ` [PATCH v2 03/25] rust: device: generalize drvdata methods over ForLt Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:50 ` [PATCH v2 04/25] rust: driver: make Adapter trait lifetime-parameterized Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:50 ` [PATCH v2 05/25] rust: pci: implement Sync for Device<Bound> Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 06/25] rust: platform: " Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 07/25] rust: auxiliary: " Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 08/25] rust: usb: " Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 09/25] rust: device: " Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:50 ` [PATCH v2 10/25] rust: pci: make Driver trait lifetime-parameterized Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:50 ` [PATCH v2 11/25] rust: platform: " Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 12/25] rust: auxiliary: " Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 13/25] rust: auxiliary: generalize Registration over ForLt Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 14/25] samples: rust: rust_driver_auxiliary: showcase lifetime-bound registration data Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 15/25] rust: usb: make Driver trait lifetime-parameterized Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 16/25] rust: i2c: " Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 17/25] rust: pci: make Bar lifetime-parameterized Danilo Krummrich
2026-05-07  3:02   ` Claude Code Review Bot [this message]
2026-05-06 21:50 ` [PATCH v2 18/25] rust: io: make IoMem and ExclusiveIoMem lifetime-parameterized Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:50 ` [PATCH v2 19/25] samples: rust: rust_driver_pci: use HRT lifetime for Bar Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:50 ` [PATCH v2 20/25] rust: driver-core: rename 'a lifetime to 'bound Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 21/25] gpu: nova-core: " Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 22/25] gpu: nova-core: use HRT lifetime for Bar Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:50 ` [PATCH v2 23/25] gpu: nova-core: unregister sysmem flush page from Drop Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:51 ` [PATCH v2 24/25] gpu: nova-core: replace ARef<Device> with &'bound Device in SysmemFlush Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-06 21:51 ` [PATCH v2 25/25] gpu: drm: tyr: use HRT lifetime for IoMem Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-05-07  3:02 ` Claude review: rust: device: Higher-Ranked Lifetime Types for device drivers Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-17  0:00 [PATCH v3 00/27] " Danilo Krummrich
2026-05-17  0:01 ` [PATCH v3 19/27] rust: pci: make Bar lifetime-parameterized Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-04-27 22:10 [PATCH 00/24] rust: device: Higher-Ranked Lifetime Types for device drivers Danilo Krummrich
2026-04-27 22:11 ` [PATCH 18/24] rust: pci: make Bar lifetime-parameterized Danilo Krummrich
2026-04-28  3:47   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch17-20260506215113.851360-18-dakr@kernel.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox