From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: pci: make Bar lifetime-parameterized
Date: Mon, 18 May 2026 16:24:35 +1000 [thread overview]
Message-ID: <review-patch19-20260517000149.3226762-20-dakr@kernel.org> (raw)
In-Reply-To: <20260517000149.3226762-20-dakr@kernel.org>
Patch Review
Adds a method to convert a lifetime-parameterized `Bar` into a `Devres<Bar>` for cases where runtime revocation is still needed:
```rust
+ pub fn into_devres(self) -> impl PinInit<Devres<Bar<'static, SIZE>>, Error> + use<'bound, SIZE>
+ where
+ Bar<'bound, SIZE>: Send + Sync,
+ {
+ Devres::new_foreign_owned(self.pdev.as_ref(), unsafe {
+ core::mem::transmute::<Bar<'bound, SIZE>, Bar<'static, SIZE>>(self)
+ })
```
**Key unsafe:** The `transmute` from `Bar<'bound>` to `Bar<'static>` erases the lifetime. This is sound because `Devres` guarantees revocation before the device unbinds (which is when `'bound` ends). The safety comment explains this well. The `where Bar<'bound, SIZE>: Send + Sync` bound is important — it prevents unsound transmutes of non-thread-safe types.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-18 6:24 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-17 0:00 [PATCH v3 00/27] rust: device: Higher-Ranked Lifetime Types for device drivers Danilo Krummrich
2026-05-17 0:00 ` [PATCH v3 01/27] rust: alloc: remove `'static` bound on `ForeignOwnable` Danilo Krummrich
2026-05-18 6:24 ` Claude review: " Claude Code Review Bot
2026-05-17 0:00 ` [PATCH v3 02/27] rust: driver: move 'static bounds to constructor Danilo Krummrich
2026-05-18 6:24 ` Claude review: " Claude Code Review Bot
2026-05-17 0:00 ` [PATCH v3 03/27] rust: driver: decouple driver private data from driver type Danilo Krummrich
2026-05-17 14:32 ` Danilo Krummrich
2026-05-18 6:24 ` Claude review: " Claude Code Review Bot
2026-05-17 0:00 ` [PATCH v3 04/27] rust: driver core: drop drvdata before devres release Danilo Krummrich
2026-05-18 6:24 ` Claude review: " Claude Code Review Bot
2026-05-17 0:00 ` [PATCH v3 05/27] rust: pci: implement Sync for Device<Bound> Danilo Krummrich
2026-05-18 6:24 ` Claude review: " Claude Code Review Bot
2026-05-17 0:00 ` [PATCH v3 06/27] rust: platform: " Danilo Krummrich
2026-05-17 0:00 ` [PATCH v3 07/27] rust: auxiliary: " Danilo Krummrich
2026-05-17 0:00 ` [PATCH v3 08/27] rust: usb: " Danilo Krummrich
2026-05-17 0:00 ` [PATCH v3 09/27] rust: device: " Danilo Krummrich
2026-05-18 6:24 ` Claude review: " Claude Code Review Bot
2026-05-17 0:00 ` [PATCH v3 10/27] rust: pci: make Driver trait lifetime-parameterized Danilo Krummrich
2026-05-17 0:00 ` [PATCH v3 11/27] rust: platform: " Danilo Krummrich
2026-05-17 0:01 ` [PATCH v3 12/27] rust: auxiliary: " Danilo Krummrich
2026-05-17 0:01 ` [PATCH v3 13/27] rust: usb: " Danilo Krummrich
2026-05-17 0:01 ` [PATCH v3 14/27] rust: i2c: " Danilo Krummrich
2026-05-17 0:01 ` [PATCH v3 15/27] rust: driver: update module documentation for GAT-based Data type Danilo Krummrich
2026-05-18 6:24 ` Claude review: " Claude Code Review Bot
2026-05-17 0:01 ` [PATCH v3 16/27] rust: types: add `ForLt` trait for higher-ranked lifetime support Danilo Krummrich
2026-05-18 6:24 ` Claude review: " Claude Code Review Bot
2026-05-17 0:01 ` [PATCH v3 17/27] rust: auxiliary: generalize Registration over ForLt Danilo Krummrich
2026-05-18 6:24 ` Claude review: " Claude Code Review Bot
2026-05-17 0:01 ` [PATCH v3 18/27] samples: rust: rust_driver_auxiliary: showcase lifetime-bound registration data Danilo Krummrich
2026-05-18 6:24 ` Claude review: " Claude Code Review Bot
2026-05-17 0:01 ` [PATCH v3 19/27] rust: pci: make Bar lifetime-parameterized Danilo Krummrich
2026-05-18 6:24 ` Claude Code Review Bot [this message]
2026-05-17 0:01 ` [PATCH v3 20/27] rust: io: make IoMem and ExclusiveIoMem lifetime-parameterized Danilo Krummrich
2026-05-18 6:24 ` Claude review: " Claude Code Review Bot
2026-05-17 0:01 ` [PATCH v3 21/27] samples: rust: rust_driver_pci: use HRT lifetime for Bar Danilo Krummrich
2026-05-18 6:24 ` Claude review: " Claude Code Review Bot
2026-05-17 0:01 ` [PATCH v3 22/27] rust: driver-core: rename 'a lifetime to 'bound Danilo Krummrich
2026-05-18 6:24 ` Claude review: " Claude Code Review Bot
2026-05-17 0:01 ` [PATCH REF v3 23/27] gpu: nova-core: " Danilo Krummrich
2026-05-18 6:24 ` Claude review: " Claude Code Review Bot
2026-05-17 0:01 ` [PATCH REF v3 24/27] gpu: nova-core: use lifetime for Bar Danilo Krummrich
2026-05-18 6:24 ` Claude review: " Claude Code Review Bot
2026-05-17 0:01 ` [PATCH REF v3 25/27] gpu: nova-core: unregister sysmem flush page from Drop Danilo Krummrich
2026-05-18 6:24 ` Claude review: " Claude Code Review Bot
2026-05-17 0:01 ` [PATCH REF v3 26/27] gpu: nova-core: replace ARef<Device> with &'bound Device in SysmemFlush Danilo Krummrich
2026-05-18 6:24 ` Claude review: " Claude Code Review Bot
2026-05-17 0:01 ` [PATCH REF v3 27/27] gpu: drm: tyr: use lifetime for IoMem Danilo Krummrich
2026-05-18 6:24 ` Claude review: " Claude Code Review Bot
2026-05-18 6:24 ` Claude review: rust: device: Higher-Ranked Lifetime Types for device drivers Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-06 21:50 [PATCH v2 00/25] " Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 17/25] rust: pci: make Bar lifetime-parameterized Danilo Krummrich
2026-05-07 3:02 ` Claude review: " Claude Code Review Bot
2026-04-27 22:10 [PATCH 00/24] rust: device: Higher-Ranked Lifetime Types for device drivers Danilo Krummrich
2026-04-27 22:11 ` [PATCH 18/24] rust: pci: make Bar lifetime-parameterized Danilo Krummrich
2026-04-28 3:47 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch19-20260517000149.3226762-20-dakr@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox