public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: samples: rust: rust_driver_pci: use HRT lifetime for Bar
Date: Mon, 18 May 2026 16:24:35 +1000	[thread overview]
Message-ID: <review-patch21-20260517000149.3226762-22-dakr@kernel.org> (raw)
In-Reply-To: <20260517000149.3226762-22-dakr@kernel.org>

Patch Review

Major rewrite demonstrating the end-to-end improvement. Before: the sample driver needed `Arc`, `Devres`, `RevocableMutex`, `ARef`, and `PinnedDrop`. After:

```rust
+struct SampleDriverData<'bound> {
+    _bar: pci::Bar<'bound>,
+    dev: &'bound pci::Device<Bound>,
+}
```

The `probe` function is dramatically simpler — no manual devres registration, no revocable wrappers:

```rust
+    fn probe<'bound>(
+        dev: &'bound mut pci::Device<Bound>,
+        _info: &pci::DeviceId,
+    ) -> Result<Pin<KBox<SampleDriverData<'bound>>>> {
+        let bar = dev.iomap_region_sized::<{ SampleDriver::MEM_SIZE }>(0)?;
+        dev_info!(dev.as_ref(), "PCI base address: {:p}\n", bar.io_addr());
+        KBox::try_pin_init(try_pin_init!(SampleDriverData {
+            _bar: bar,
+            dev: dev.into(),
+        }), GFP_KERNEL)
+    }
```

This is the best demonstration of the series' value. The code is clearer, safer (compile-time vs. runtime checks), and shorter.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-18  6:24 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-17  0:00 [PATCH v3 00/27] rust: device: Higher-Ranked Lifetime Types for device drivers Danilo Krummrich
2026-05-17  0:00 ` [PATCH v3 01/27] rust: alloc: remove `'static` bound on `ForeignOwnable` Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-05-17  0:00 ` [PATCH v3 02/27] rust: driver: move 'static bounds to constructor Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-05-17  0:00 ` [PATCH v3 03/27] rust: driver: decouple driver private data from driver type Danilo Krummrich
2026-05-17 14:32   ` Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-05-17  0:00 ` [PATCH v3 04/27] rust: driver core: drop drvdata before devres release Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-05-17  0:00 ` [PATCH v3 05/27] rust: pci: implement Sync for Device<Bound> Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-05-17  0:00 ` [PATCH v3 06/27] rust: platform: " Danilo Krummrich
2026-05-17  0:00 ` [PATCH v3 07/27] rust: auxiliary: " Danilo Krummrich
2026-05-17  0:00 ` [PATCH v3 08/27] rust: usb: " Danilo Krummrich
2026-05-17  0:00 ` [PATCH v3 09/27] rust: device: " Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-05-17  0:00 ` [PATCH v3 10/27] rust: pci: make Driver trait lifetime-parameterized Danilo Krummrich
2026-05-17  0:00 ` [PATCH v3 11/27] rust: platform: " Danilo Krummrich
2026-05-17  0:01 ` [PATCH v3 12/27] rust: auxiliary: " Danilo Krummrich
2026-05-17  0:01 ` [PATCH v3 13/27] rust: usb: " Danilo Krummrich
2026-05-17  0:01 ` [PATCH v3 14/27] rust: i2c: " Danilo Krummrich
2026-05-17  0:01 ` [PATCH v3 15/27] rust: driver: update module documentation for GAT-based Data type Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-05-17  0:01 ` [PATCH v3 16/27] rust: types: add `ForLt` trait for higher-ranked lifetime support Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-05-17  0:01 ` [PATCH v3 17/27] rust: auxiliary: generalize Registration over ForLt Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-05-17  0:01 ` [PATCH v3 18/27] samples: rust: rust_driver_auxiliary: showcase lifetime-bound registration data Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-05-17  0:01 ` [PATCH v3 19/27] rust: pci: make Bar lifetime-parameterized Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-05-17  0:01 ` [PATCH v3 20/27] rust: io: make IoMem and ExclusiveIoMem lifetime-parameterized Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-05-17  0:01 ` [PATCH v3 21/27] samples: rust: rust_driver_pci: use HRT lifetime for Bar Danilo Krummrich
2026-05-18  6:24   ` Claude Code Review Bot [this message]
2026-05-17  0:01 ` [PATCH v3 22/27] rust: driver-core: rename 'a lifetime to 'bound Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-05-17  0:01 ` [PATCH REF v3 23/27] gpu: nova-core: " Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-05-17  0:01 ` [PATCH REF v3 24/27] gpu: nova-core: use lifetime for Bar Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-05-17  0:01 ` [PATCH REF v3 25/27] gpu: nova-core: unregister sysmem flush page from Drop Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-05-17  0:01 ` [PATCH REF v3 26/27] gpu: nova-core: replace ARef<Device> with &'bound Device in SysmemFlush Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-05-17  0:01 ` [PATCH REF v3 27/27] gpu: drm: tyr: use lifetime for IoMem Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-05-18  6:24 ` Claude review: rust: device: Higher-Ranked Lifetime Types for device drivers Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-06 21:50 [PATCH v2 00/25] " Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 19/25] samples: rust: rust_driver_pci: use HRT lifetime for Bar Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot
2026-04-27 22:10 [PATCH 00/24] rust: device: Higher-Ranked Lifetime Types for device drivers Danilo Krummrich
2026-04-27 22:11 ` [PATCH 20/24] samples: rust: rust_driver_pci: use HRT lifetime for Bar Danilo Krummrich
2026-04-28  3:47   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch21-20260517000149.3226762-22-dakr@kernel.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox