public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: replace ARef<Device> with &'bound Device in SysmemFlush
Date: Wed, 27 May 2026 15:28:23 +1000	[thread overview]
Message-ID: <review-patch3-20260525225838.276108-4-dakr@kernel.org> (raw)
In-Reply-To: <20260525225838.276108-4-dakr@kernel.org>

Patch Review

Straightforward simplification now that `SysmemFlush<'sys>` has a lifetime parameter.

```rust
-    device: ARef<device::Device>,
+    device: &'sys device::Device,
```

And in `register()`:

```rust
-        dev: &device::Device<device::Bound>,
+        dev: &'sys device::Device<device::Bound>,
```

With:

```rust
-            device: dev.into(),
+            device: dev,
```

**One observation:** The `device` field type is `&'sys device::Device` (unparameterized), but the `register()` function takes `&'sys device::Device<device::Bound>`. The assignment `device: dev` works because `device::Device<device::Bound>` derefs to `device::Device` (the unparameterized form). This is an implicit coercion that's standard in the kernel Rust device model — just noting it for clarity.

The `ARef` import removal is clean. No issues found.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-27  5:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25 22:58 [PATCH 0/5] gpu: nova: adopt driver lifetime infrastructure Danilo Krummrich
2026-05-25 22:58 ` [PATCH 1/5] gpu: nova-core: use lifetime for Bar Danilo Krummrich
2026-05-26  2:06   ` Eliot Courtney
2026-05-27  5:28   ` Claude review: " Claude Code Review Bot
2026-05-25 22:58 ` [PATCH 2/5] gpu: nova-core: unregister sysmem flush page from Drop Danilo Krummrich
2026-05-26  1:43   ` Eliot Courtney
2026-05-27  5:28   ` Claude review: " Claude Code Review Bot
2026-05-25 22:58 ` [PATCH 3/5] gpu: nova-core: replace ARef<Device> with &'bound Device in SysmemFlush Danilo Krummrich
2026-05-26  1:44   ` Eliot Courtney
2026-05-27  5:28   ` Claude Code Review Bot [this message]
2026-05-25 22:58 ` [PATCH 4/5] gpu: nova-core: gsp: replace ARef<Device> with &'a Device in sequencer Danilo Krummrich
2026-05-26  1:44   ` Eliot Courtney
2026-05-27  5:28   ` Claude review: " Claude Code Review Bot
2026-05-25 22:58 ` [PATCH 5/5] gpu: nova: separate driver type from driver data Danilo Krummrich
2026-05-26  1:46   ` Eliot Courtney
2026-05-27  5:28   ` Claude review: " Claude Code Review Bot
2026-05-26  7:11 ` [PATCH 0/5] gpu: nova: adopt driver lifetime infrastructure Alexandre Courbot
2026-05-27  5:28 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-17  0:00 [PATCH v3 00/27] rust: device: Higher-Ranked Lifetime Types for device drivers Danilo Krummrich
2026-05-17  0:01 ` [PATCH REF v3 26/27] gpu: nova-core: replace ARef<Device> with &'bound Device in SysmemFlush Danilo Krummrich
2026-05-18  6:24   ` Claude review: " Claude Code Review Bot
2026-05-06 21:50 [PATCH v2 00/25] rust: device: Higher-Ranked Lifetime Types for device drivers Danilo Krummrich
2026-05-06 21:51 ` [PATCH v2 24/25] gpu: nova-core: replace ARef<Device> with &'bound Device in SysmemFlush Danilo Krummrich
2026-05-07  3:02   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260525225838.276108-4-dakr@kernel.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox