public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: use DisplayID panel type in dm_set_panel_type
Date: Wed, 27 May 2026 15:16:43 +1000	[thread overview]
Message-ID: <review-patch3-20260526030254.1460480-4-chen-yu.chen@amd.com> (raw)
In-Reply-To: <20260526030254.1460480-4-chen-yu.chen@amd.com>

Patch Review

**Status: Looks good.**

The patch correctly replaces the TODO comment with working code. The insertion point after DPCD and before the Samsung luminance heuristic gives the right priority: VSDB > DPCD > DisplayID > Samsung heuristic.

The mapping between the two enum spaces is correct:
- `DRM_MODE_PANEL_TYPE_LCD (2)` → `PANEL_TYPE_LCD (1)` from `dc_types.h`
- `DRM_MODE_PANEL_TYPE_OLED (1)` → `PANEL_TYPE_OLED (2)` from `dc_types.h`

These are different numbering spaces, and the explicit if/else-if mapping handles the translation correctly without assuming the values match.

The LCD property exposure at the end of the function:
```c
else if (link->panel_type == PANEL_TYPE_LCD)
    drm_object_property_set_value(&connector->base,
        adev_to_drm(adev)->mode_config.panel_type_property,
        DRM_MODE_PANEL_TYPE_LCD);
```
is correctly placed between the OLED and UNKNOWN branches.

**Note:** `PANEL_TYPE_MINILED` still falls through to `DRM_MODE_PANEL_TYPE_UNKNOWN` in the property setting. This is pre-existing behavior, not introduced by this patch, but it means mini-LED panels detected via VSDB/DPCD won't be exposed as a distinct type to userspace. This could be a follow-up enhancement.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-27  5:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26  2:59 [PATCH v3 0/3] drm: detect panel type from DisplayID 2.x Chenyu Chen
2026-05-26  2:59 ` [PATCH v3 1/3] drm/edid: extract base section header processing into helper Chenyu Chen
2026-05-26  3:09   ` Chen, Chen-Yu
2026-05-27  5:16   ` Claude review: " Claude Code Review Bot
2026-05-26  2:59 ` [PATCH v3 2/3] drm/edid: parse panel type from DisplayID 2.x Display Parameters Chenyu Chen
2026-05-26  3:09   ` Chen, Chen-Yu
2026-05-27  5:16   ` Claude review: " Claude Code Review Bot
2026-05-26  2:59 ` [PATCH v3 3/3] drm/amd/display: use DisplayID panel type in dm_set_panel_type Chenyu Chen
2026-05-26  3:09   ` Chen, Chen-Yu
2026-05-27  5:16   ` Claude Code Review Bot [this message]
2026-05-27  5:16 ` Claude review: drm: detect panel type from DisplayID 2.x Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-20  2:13 [PATCH v2 0/3] " Chenyu Chen
2026-05-20  2:13 ` [PATCH v2 3/3] drm/amd/display: use DisplayID panel type in dm_set_panel_type Chenyu Chen
2026-05-25 12:19   ` Claude review: " Claude Code Review Bot
2026-05-14  6:54 [PATCH 0/2] drm: detect panel type from DisplayID 2.x Chenyu Chen
2026-05-14  6:54 ` [PATCH 2/2] drm/amd/display: use DisplayID panel type in dm_set_panel_type Chenyu Chen
2026-05-16  1:17   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260526030254.1460480-4-chen-yu.chen@amd.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox