public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panic: Look up glyph shape with font helper
Date: Thu, 04 Jun 2026 16:27:41 +1000	[thread overview]
Message-ID: <review-patch3-20260529140759.529929-4-tzimmermann@suse.de> (raw)
In-Reply-To: <20260529140759.529929-4-tzimmermann@suse.de>

Patch Review

Converts `draw_txt_rectangle()` in `drm_panic.c`:

```c
-			src = drm_draw_get_char_bitmap(font, msg[i].txt[j], font_pitch);
+			src = font_data_glyph_buf(font->data, font->width, font->height,
+						  (unsigned char)msg[i].txt[j]);
 			rec.x2 = rec.x1 + font->width;
-			drm_panic_blit(sb, &rec, src, font_pitch, 1, color);
+			if (src)
+				drm_panic_blit(sb, &rec, src, font_pitch, 1, color);
 			rec.x1 += font->width;
```

Same pattern as patch 2. `rec.x2` is set before the NULL check, but this is harmless — it gets overwritten on the next loop iteration regardless.

The bounds checking is especially valuable in panic context where safety is paramount and we must not compound a crash with a second fault from an out-of-bounds font read.

**No bugs. Looks good.**

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-06-04  6:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-29 14:01 [PATCH 0/4] drm: Safe font-data access in log/panic drawing Thomas Zimmermann
2026-05-29 14:01 ` [PATCH 1/4] lib/fonts: Look up glyph data with font_data_glyph_buf() Thomas Zimmermann
2026-06-01 11:18   ` Jocelyn Falempe
2026-06-02  8:08     ` Thomas Zimmermann
2026-06-04  6:27   ` Claude review: " Claude Code Review Bot
2026-05-29 14:01 ` [PATCH 2/4] drm/client: log: Look up glyph shape with font helper Thomas Zimmermann
2026-06-01 11:19   ` Jocelyn Falempe
2026-06-04  6:27   ` Claude review: " Claude Code Review Bot
2026-05-29 14:01 ` [PATCH 3/4] drm/panic: " Thomas Zimmermann
2026-06-01 11:19   ` Jocelyn Falempe
2026-06-04  6:27   ` Claude Code Review Bot [this message]
2026-05-29 14:01 ` [PATCH 4/4] drm/draw: Remove unused helper drm_draw_get_char_bitmap() Thomas Zimmermann
2026-06-01 11:19   ` Jocelyn Falempe
2026-06-04  6:27   ` Claude review: " Claude Code Review Bot
2026-06-04  6:27 ` Claude review: drm: Safe font-data access in log/panic drawing Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260529140759.529929-4-tzimmermann@suse.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox