From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/draw: Remove unused helper drm_draw_get_char_bitmap()
Date: Thu, 04 Jun 2026 16:27:42 +1000 [thread overview]
Message-ID: <review-patch4-20260529140759.529929-5-tzimmermann@suse.de> (raw)
In-Reply-To: <20260529140759.529929-5-tzimmermann@suse.de>
Patch Review
Removes the now-dead inline:
```c
-#include <linux/font.h>
...
-static inline const u8 *drm_draw_get_char_bitmap(const struct font_desc *font,
- char c, size_t font_pitch)
-{
- return font->data + (c * font->height) * font_pitch;
-}
```
Also removes the `#include <linux/font.h>` that was only needed for this helper. The remaining code in the header (`drm_draw_is_pixel_fg`) only uses `u8` from `<linux/types.h>` which is still included.
I confirmed these were the only two callers of `drm_draw_get_char_bitmap` in the tree, so the removal is safe.
**No bugs. Looks good.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 6:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 14:01 [PATCH 0/4] drm: Safe font-data access in log/panic drawing Thomas Zimmermann
2026-05-29 14:01 ` [PATCH 1/4] lib/fonts: Look up glyph data with font_data_glyph_buf() Thomas Zimmermann
2026-06-01 11:18 ` Jocelyn Falempe
2026-06-02 8:08 ` Thomas Zimmermann
2026-06-04 6:27 ` Claude review: " Claude Code Review Bot
2026-05-29 14:01 ` [PATCH 2/4] drm/client: log: Look up glyph shape with font helper Thomas Zimmermann
2026-06-01 11:19 ` Jocelyn Falempe
2026-06-04 6:27 ` Claude review: " Claude Code Review Bot
2026-05-29 14:01 ` [PATCH 3/4] drm/panic: " Thomas Zimmermann
2026-06-01 11:19 ` Jocelyn Falempe
2026-06-04 6:27 ` Claude review: " Claude Code Review Bot
2026-05-29 14:01 ` [PATCH 4/4] drm/draw: Remove unused helper drm_draw_get_char_bitmap() Thomas Zimmermann
2026-06-01 11:19 ` Jocelyn Falempe
2026-06-04 6:27 ` Claude Code Review Bot [this message]
2026-06-04 6:27 ` Claude review: drm: Safe font-data access in log/panic drawing Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260529140759.529929-5-tzimmermann@suse.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox