Claude review: drm/i915/display/intel_dp: Drop redundant intel_dp_aux_fini() on init failure

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Verdict: Correct.**

The analysis is clear:

1. When `intel_edp_init_connector()` fails, the code calls `intel_dp_aux_fini(intel_dp)` then jumps to `fail:`.

2. The `fail:` label at line 7467 calls `drm_connector_cleanup()`. The connector was initialized with `intel_dp_connector_funcs` which has `.destroy` — but `drm_connector_cleanup()` does NOT call `.destroy`, it just removes from the list and cleans up state.

3. However, the *encoder* will still have its `.destroy` callback called during device teardown — either `intel_dp_encoder_destroy` or `intel_ddi_encoder_destroy`, both of which call `intel_dp_encoder_flush_work()`, which calls `intel_dp_aux_fini()` at line 6811.

4. So `intel_dp_aux_fini()` would be called twice: once explicitly in the error path, and once via the encoder destroy callback.

The fix correctly removes the explicit call, keeping only the one in the encoder destroy path. The `intel_dp_aux_fini()` function unregisters the aux I2C adapter, and calling it twice would indeed be problematic (double unregister/double kfree of adapter name).

One minor note: the patch also changes the code style from a `{ }` block to a bare `if` statement with the `goto`, which is fine since the single statement no longer needs braces.

**Clean and correct fix.**

---
Generated by Claude Code Patch Reviewer