From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/i915: Fix double cleanup in error paths
Date: Thu, 04 Jun 2026 11:52:28 +1000 [thread overview]
Message-ID: <review-overall-20260603-fix_i915-v1-0-7479ff64e705@bootlin.com> (raw)
In-Reply-To: <20260603-fix_i915-v1-0-7479ff64e705@bootlin.com>
Overall Series Review
Subject: drm/i915: Fix double cleanup in error paths
Author: Kory Maincent <kory.maincent@bootlin.com>
Patches: 6
Reviewed: 2026-06-04T11:52:28.153352
---
This is a 3-patch series fixing double-cleanup issues in i915 display connector/encoder error paths. The core claim is correct for patches 1 and 3: once `drm_connector_init_with_ddc()` succeeds, the DRM core owns the object and will call `.destroy` during teardown, so manual cleanup in error paths causes double-free. However, **patch 2 has a significant problem** — it introduces a resource leak by removing cleanup that is actually needed.
The series is Cc: stable, which is appropriate for patches 1 and 3 but patch 2 needs rework. Overall the direction is right but the LVDS patch needs a different approach.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-06-04 1:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 8:59 [PATCH 0/3] drm/i915: Fix double cleanup in error paths Kory Maincent
2026-06-03 8:59 ` [PATCH 1/3] drm/i915/display/intel_sdvo: Fix double connector destroy " Kory Maincent
2026-06-04 1:52 ` Claude review: " Claude Code Review Bot
2026-06-03 8:59 ` [PATCH 2/3] drm/i915/display/intel_lvds: Drop redundant manual cleanup on init failure Kory Maincent
2026-06-04 1:52 ` Claude review: " Claude Code Review Bot
2026-06-03 8:59 ` [PATCH 3/3] drm/i915/display/intel_dp: Drop redundant intel_dp_aux_fini() " Kory Maincent
2026-06-03 11:58 ` Imre Deak
2026-06-04 1:52 ` Claude review: " Claude Code Review Bot
2026-06-03 16:35 ` [PATCH 0/3] drm/i915: Fix double cleanup in error paths Kory Maincent
2026-06-04 1:52 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260603-fix_i915-v1-0-7479ff64e705@bootlin.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox