public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: soc: qcom: ubwc: Add Shikra UBWC config
Date: Fri, 05 Jun 2026 06:28:18 +1000	[thread overview]
Message-ID: <review-patch3-20260604-shikra-display-v2-3-b3c1b2b67edc@oss.qualcomm.com> (raw)
In-Reply-To: <20260604-shikra-display-v2-3-b3c1b2b67edc@oss.qualcomm.com>

Patch Review

```diff
+	{ .compatible = "qcom,shikra", .data = &qcm2290_data, },
```

Clean one-liner. The entry is correctly placed alphabetically (between `qcom,sdm845` and `qcom,sm4250`). Mapping to `qcm2290_data` is correct — this struct is defined as:

```c
static const struct qcom_ubwc_cfg_data qcm2290_data = {
	/* no UBWC */
	.highest_bank_bit = 15,
};
```

Since Shikra shares the same hardware as QCM2290, using the same UBWC config (which essentially disables UBWC but sets the correct `highest_bank_bit`) is the right choice. This also addresses the v1 feedback where `no_ubwc_data` was used incorrectly.

**Minor:** The commit message is missing a period at the end of "...for the UBWC settings". Trivial.

No functional issues.

---

### Additional notes on the cover letter

1. **Duplicate Subject prefix:** The cover letter subject reads `"Subject: [PATCH v2 0/3] Subject: [PATCH 0/3] Add Shikra..."` — the nested `Subject:` should be removed.

2. **Stale diffstat:** The first diffstat in the cover letter (lines after the shortlog) lists `drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 +` and counts "5 files changed" while listing 6 files. This is a leftover from v1. The second diffstat (at the bottom) is correct. The stale one should be cleaned up in a v3 if one is needed.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-06-04 20:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-04 12:30 [PATCH v2 0/3] Subject: [PATCH 0/3] Add Shikra (QCM2390) display support Nabige Aala
2026-06-04 12:30 ` [PATCH v2 1/3] dt-bindings: display: msm: qcm2290: Add Shikra MDSS Nabige Aala
2026-06-04 12:42   ` sashiko-bot
2026-06-04 12:51   ` Krzysztof Kozlowski
2026-06-04 12:51   ` Dmitry Baryshkov
2026-06-04 20:28   ` Claude review: " Claude Code Review Bot
2026-06-04 12:30 ` [PATCH v2 2/3] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala
2026-06-04 12:37   ` sashiko-bot
2026-06-04 12:53   ` Krzysztof Kozlowski
2026-06-04 16:12     ` Krzysztof Kozlowski
2026-06-04 12:54   ` Dmitry Baryshkov
2026-06-04 20:28   ` Claude review: " Claude Code Review Bot
2026-06-04 12:30 ` [PATCH v2 3/3] soc: qcom: ubwc: Add Shikra UBWC config Nabige Aala
2026-06-04 13:04   ` Dmitry Baryshkov
2026-06-04 20:28   ` Claude Code Review Bot [this message]
2026-06-04 13:03 ` [PATCH v2 0/3] Subject: [PATCH 0/3] Add Shikra (QCM2390) display support Dmitry Baryshkov
2026-06-04 20:28 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-06-03 14:59 [PATCH 0/5] Subject: [PATCH 0/5] Add Shikra (QCM2290) " Nabige Aala
2026-06-03 14:59 ` [PATCH 4/5] soc: qcom: ubwc: Add Shikra UBWC config Nabige Aala
2026-06-04  1:45   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260604-shikra-display-v2-3-b3c1b2b67edc@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox