public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: msm: qcm2290: Add Shikra MDSS
Date: Fri, 05 Jun 2026 06:28:17 +1000	[thread overview]
Message-ID: <review-patch1-20260604-shikra-display-v2-1-b3c1b2b67edc@oss.qualcomm.com> (raw)
In-Reply-To: <20260604-shikra-display-v2-1-b3c1b2b67edc@oss.qualcomm.com>

Patch Review

This is the substantive patch of the series. The changes are well-structured.

**select block (qcom,qcm2290-mdss.yaml):** Adding the `select` block is correct and necessary. Since `mdss-common.yaml` uses `select: false`, and none of the other MDSS binding files in the tree use an explicit `select`, the default filename-based schema matching would fail for DT nodes whose first compatible is `qcom,shikra-mdss`. The `contains: enum: [qcom,qcm2290-mdss]` approach ensures this schema is applied whenever `qcom,qcm2290-mdss` appears anywhere in the compatible list, covering both the standalone and fallback cases.

**Title fix:** The title change from `"Qualcomm QCM220 Display MDSS"` to `"Qualcomm QCM2290 and Shikra Display MDSS"` is a nice drive-by fix of a pre-existing typo ("QCM220" → "QCM2290").

**DPU binding (qcom,qcm2290-dpu.yaml):** Minor nit — the diff removes the blank line that separated `compatible:` from `reg:`:

```diff
   compatible:
-    const: qcom,qcm2290-dpu
-
+    oneOf:
+      - const: qcom,qcm2290-dpu
+      - items:
+          - const: qcom,shikra-dpu
+          - const: qcom,qcm2290-dpu
   reg:
```

The blank line before `reg:` was a visual separator between properties. Its removal won't break validation, but it's inconsistent with the style in the rest of the file and other binding files. Worth keeping for readability.

**DSI compatible chain (qcom,qcm2290-mdss.yaml):** The Shikra DSI compatible is defined as a 3-item chain: `qcom,shikra-dsi-ctrl`, `qcom,qcm2290-dsi-ctrl`, `qcom,mdss-dsi-ctrl`. This is correct — the kernel DSI driver will match on the `qcom,qcm2290-dsi-ctrl` or `qcom,mdss-dsi-ctrl` fallbacks.

**dsi-controller-main.yaml:** Adding `qcom,shikra-dsi-ctrl` in alphabetical order between `qcom,sdm845-dsi-ctrl` and `qcom,sm6115-dsi-ctrl` is correct.

No functional issues found.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-06-04 20:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-04 12:30 [PATCH v2 0/3] Subject: [PATCH 0/3] Add Shikra (QCM2390) display support Nabige Aala
2026-06-04 12:30 ` [PATCH v2 1/3] dt-bindings: display: msm: qcm2290: Add Shikra MDSS Nabige Aala
2026-06-04 12:42   ` sashiko-bot
2026-06-04 12:51   ` Krzysztof Kozlowski
2026-06-04 12:51   ` Dmitry Baryshkov
2026-06-04 20:28   ` Claude Code Review Bot [this message]
2026-06-04 12:30 ` [PATCH v2 2/3] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala
2026-06-04 12:37   ` sashiko-bot
2026-06-04 12:53   ` Krzysztof Kozlowski
2026-06-04 16:12     ` Krzysztof Kozlowski
2026-06-04 12:54   ` Dmitry Baryshkov
2026-06-04 20:28   ` Claude review: " Claude Code Review Bot
2026-06-04 12:30 ` [PATCH v2 3/3] soc: qcom: ubwc: Add Shikra UBWC config Nabige Aala
2026-06-04 13:04   ` Dmitry Baryshkov
2026-06-04 20:28   ` Claude review: " Claude Code Review Bot
2026-06-04 13:03 ` [PATCH v2 0/3] Subject: [PATCH 0/3] Add Shikra (QCM2390) display support Dmitry Baryshkov
2026-06-04 20:28 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-06-03 14:59 [PATCH 0/5] Subject: [PATCH 0/5] Add Shikra (QCM2290) " Nabige Aala
2026-06-03 14:59 ` [PATCH 1/5] dt-bindings: display: msm: qcm2290: Add Shikra MDSS Nabige Aala
2026-06-04  1:45   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260604-shikra-display-v2-1-b3c1b2b67edc@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox