public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: msm: qcm2290: Add Shikra MDSS
Date: Thu, 04 Jun 2026 11:45:50 +1000	[thread overview]
Message-ID: <review-patch1-20260603-shikra-display-v1-1-aeac1b94faa7@oss.qualcomm.com> (raw)
In-Reply-To: <20260603-shikra-display-v1-1-aeac1b94faa7@oss.qualcomm.com>

Patch Review

This patch updates three YAML binding files to accept Shikra compatibles alongside QCM2290.

**Design concern — fallback compatibles**: Since the cover letter states Shikra "reuses the same MDSS/DPU 6.5 hardware as QCM2290" with "the same register layout," the idiomatic DT approach for identical hardware is to use fallback compatibles. For example, the MDSS binding would express:

```yaml
compatible:
  items:
    - enum:
        - qcom,shikra-mdss
    - const: qcom,qcm2290-mdss
```

This keeps Shikra's own compatible for future-proofing while allowing the driver to match on the existing `qcom,qcm2290-mdss` entry — no driver code changes needed. The same applies to the DPU and DSI controller compatibles. DT maintainers (Krzysztof, Rob) typically prefer this pattern.

**qcom,qcm2290-mdss.yaml changes look correct**: The `select:` block is properly added to ensure the schema matches both compatible values. The `patternProperties` for DPU and DSI child nodes are correctly extended.

**DSI controller binding in dsi-controller-main.yaml**: Adding `qcom,shikra-dsi-ctrl` in alphabetical order is correct. The DSI node in the MDSS binding properly pairs it with `qcom,mdss-dsi-ctrl` as fallback, which is consistent with how other SoCs work.

**Nit**: The title update from "QCM220" to "QCM2290" is a good fix of a pre-existing typo, but mixing a typo fix into a feature patch is slightly unusual. Not a blocker.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-06-04  1:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03 14:59 [PATCH 0/5] Subject: [PATCH 0/5] Add Shikra (QCM2290) display support Nabige Aala
2026-06-03 14:59 ` [PATCH 1/5] dt-bindings: display: msm: qcm2290: Add Shikra MDSS Nabige Aala
2026-06-03 23:08   ` Dmitry Baryshkov
2026-06-04  1:45   ` Claude Code Review Bot [this message]
2026-06-03 14:59 ` [PATCH 2/5] drm/msm/mdss: Add Shikra support Nabige Aala
2026-06-03 23:09   ` Dmitry Baryshkov
2026-06-04  1:45   ` Claude review: " Claude Code Review Bot
2026-06-03 14:59 ` [PATCH 3/5] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala
2026-06-03 23:09   ` Dmitry Baryshkov
2026-06-04  1:45   ` Claude review: " Claude Code Review Bot
2026-06-03 14:59 ` [PATCH 4/5] soc: qcom: ubwc: Add Shikra UBWC config Nabige Aala
2026-06-03 23:12   ` Dmitry Baryshkov
2026-06-04  1:45   ` Claude review: " Claude Code Review Bot
2026-06-03 14:59 ` [PATCH 5/5] iommu/arm-smmu: Add qcom,shikra-mdss to Qualcomm SMMU client tables Nabige Aala
2026-06-03 23:11   ` Dmitry Baryshkov
2026-06-04  1:45   ` Claude review: " Claude Code Review Bot
2026-06-04  1:45 ` Claude review: Subject: [PATCH 0/5] Add Shikra (QCM2290) display support Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-06-04 12:30 [PATCH v2 0/3] Subject: [PATCH 0/3] Add Shikra (QCM2390) " Nabige Aala
2026-06-04 12:30 ` [PATCH v2 1/3] dt-bindings: display: msm: qcm2290: Add Shikra MDSS Nabige Aala
2026-06-04 20:28   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260603-shikra-display-v1-1-aeac1b94faa7@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox