Claude review: Subject: [PATCH 0/5] Add Shikra (QCM2290) display support

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Subject: [PATCH 0/5] Add Shikra (QCM2290) display support
Author: Nabige Aala <nabige.aala@oss.qualcomm.com>
Patches: 11
Reviewed: 2026-06-04T11:45:49.945957

---

This is a 5-patch series adding display subsystem support for the Qualcomm Shikra (QCM2290) SoC. The series is straightforward: Shikra reuses the same MDSS/DPU 6.5 hardware as QCM2290, so the patches are mostly adding new compatible strings pointing to existing driver data structures and catalog entries.

The series is generally correct and functional, but has two categories of issues:

1. **Sorting violations**: Several of the `of_device_id` match table insertions break the established alphabetical ordering in the SMMU tables and perpetuate an existing sort anomaly in the DPU/MDSS tables.

2. **Design question on fallback compatibles**: Since Shikra uses identical hardware to QCM2290, the standard DT convention would be to use fallback compatibles in the device tree (e.g., `compatible = "qcom,shikra-dpu", "qcom,qcm2290-dpu"`). This would avoid needing new match table entries in `dpu_kms.c` and `msm_mdss.c` entirely — the driver would match on the existing `qcom,qcm2290-*` entries. The DSI controller already implicitly uses this pattern via the `qcom,mdss-dsi-ctrl` fallback. The DT maintainers will likely raise this.

The cover letter has a malformed Subject line with a duplicate prefix: `[PATCH 0/5] Subject: [PATCH 0/5] Add Shikra...`

No DTS file is included — presumably that will come in a separate series.

---

---
Generated by Claude Code Patch Reviewer