From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: iommu/arm-smmu: Add qcom,shikra-mdss to Qualcomm SMMU client tables
Date: Thu, 04 Jun 2026 11:45:51 +1000 [thread overview]
Message-ID: <review-patch5-20260603-shikra-display-v1-5-aeac1b94faa7@oss.qualcomm.com> (raw)
In-Reply-To: <20260603-shikra-display-v1-5-aeac1b94faa7@oss.qualcomm.com>
Patch Review
**Sorting violation in `qcom_smmu_actlr_client_of_match[]`**: The existing table is strictly alphabetically sorted (`qcm2290` → `sa8775p` → `sc7280` → `sc8180x` → `sc8280xp` → `sm6115` → ...). The patch inserts `shikra-mdss` between `qcm2290-mdss` and `sa8775p-mdss`:
```c
{ .compatible = "qcom,qcm2290-mdss",
.data = (const void *) (PREFETCH_SHALLOW | CPRE | CMTLB) },
+ { .compatible = "qcom,shikra-mdss",
+ .data = (const void *) (PREFETCH_SHALLOW | CPRE | CMTLB) },
{ .compatible = "qcom,sa8775p-mdss",
```
Alphabetically `"sh" > "sc"`, so `shikra-mdss` should go between `sc8280xp-mdss` and `sm6115-mdss`.
**Same issue in `qcom_smmu_client_of_match[]`**: The existing table is alphabetically sorted (`qcm2290-mdss` → `sar2130p-mdss` → `sc7180-mdss` → ... → `sdm845-mdss` → `sm6115-mdss` → ...). The patch inserts `shikra-mdss` between `qcm2290-mdss` and `sar2130p-mdss`:
```c
{ .compatible = "qcom,qcm2290-mdss" },
+ { .compatible = "qcom,shikra-mdss" },
{ .compatible = "qcom,sar2130p-mdss" },
```
The correct position would be between `sdm845-mdss` and `sm6115-mdss`.
**Functionally correct**: The SMMU prefetch settings (`PREFETCH_SHALLOW | CPRE | CMTLB`) matching QCM2290 makes sense given identical display hardware. The client table entry is needed since there's no fallback compatible at the SMMU client match level.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 1:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 14:59 [PATCH 0/5] Subject: [PATCH 0/5] Add Shikra (QCM2290) display support Nabige Aala
2026-06-03 14:59 ` [PATCH 1/5] dt-bindings: display: msm: qcm2290: Add Shikra MDSS Nabige Aala
2026-06-03 23:08 ` Dmitry Baryshkov
2026-06-04 1:45 ` Claude review: " Claude Code Review Bot
2026-06-03 14:59 ` [PATCH 2/5] drm/msm/mdss: Add Shikra support Nabige Aala
2026-06-03 23:09 ` Dmitry Baryshkov
2026-06-04 1:45 ` Claude review: " Claude Code Review Bot
2026-06-03 14:59 ` [PATCH 3/5] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala
2026-06-03 23:09 ` Dmitry Baryshkov
2026-06-04 1:45 ` Claude review: " Claude Code Review Bot
2026-06-03 14:59 ` [PATCH 4/5] soc: qcom: ubwc: Add Shikra UBWC config Nabige Aala
2026-06-03 23:12 ` Dmitry Baryshkov
2026-06-04 1:45 ` Claude review: " Claude Code Review Bot
2026-06-03 14:59 ` [PATCH 5/5] iommu/arm-smmu: Add qcom,shikra-mdss to Qualcomm SMMU client tables Nabige Aala
2026-06-03 23:11 ` Dmitry Baryshkov
2026-06-04 1:45 ` Claude Code Review Bot [this message]
2026-06-04 1:45 ` Claude review: Subject: [PATCH 0/5] Add Shikra (QCM2290) display support Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch5-20260603-shikra-display-v1-5-aeac1b94faa7@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox