public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: simple: add Waveshare LCD panels
Date: Tue, 31 Mar 2026 17:17:01 +1000	[thread overview]
Message-ID: <review-patch4-20260330-ws-lcd-v1-4-309834a435c0@oss.qualcomm.com> (raw)
In-Reply-To: <20260330-ws-lcd-v1-4-309834a435c0@oss.qualcomm.com>

Patch Review

This is the main patch adding 15 panel definitions (~381 lines). A few issues:

**1. Missing trailing commas in OF match table (style issue):**

Every new entry is missing a trailing comma after `.data`:

```c
	}, {
		.compatible = "waveshare,2.8inch-panel",
		.data = &waveshare_28_lcd_panel
	}, {
```

The existing code uses trailing commas consistently (e.g., `.data = &waveshare_133inch,`). All 15 new entries should have trailing commas added for consistency with the rest of the file.

**2. Forward declaration of `waveshare_80_lcd_c_mode`:**

```c
static const struct drm_display_mode waveshare_80_lcd_c_mode;
static const struct panel_desc waveshare_70_lcd_e_panel = {
	.modes = &waveshare_80_lcd_c_mode,
	...
};
```

The actual definition of `waveshare_80_lcd_c_mode` comes ~60 lines later. While this is valid C (tentative definition completed by the later actual definition), it's an unusual pattern in panel-simple.c. It would be cleaner to simply reorder the definitions so `waveshare_80_lcd_c_mode` is defined before `waveshare_70_lcd_e_panel`, just as `waveshare_50_lcd_c_mode` is defined before `waveshare_70_lcd_c_panel` which also shares a mode.

**3. Mode reuse is good but should be documented:**

Several panels share modes (same resolution/timings, different physical sizes):
- `waveshare_70_lcd_c_panel` reuses `waveshare_50_lcd_c_mode` (1024x600)
- `waveshare_70_lcd_e_panel` reuses `waveshare_80_lcd_c_mode` (1280x800)
- `waveshare_101_lcd_c_panel` reuses `waveshare_80_lcd_c_mode` (1280x800)

This is fine and avoids duplication, but the forward declaration for one of them (point 2) should be avoided by reordering.

**4. Minor commit message typo:** "serie" should be "series":
```
Waveshare have a serie of DSI panel kits
```

**5. Pixel format caveat:** The commit message honestly notes:
```
Note, since the panels are hidden behind the bridges which are not being
programmed by the kernel, I could not confirm the pixel format for the
panels.
```

This is good transparency but worth flagging — the DPI panels use `MEDIA_BUS_FMT_RGB888_1X24` and the LVDS panels use `MEDIA_BUS_FMT_RGB888_1X7X4_SPWG`. If any panel actually uses a different LVDS mapping (e.g., JEIDA), it would produce incorrect colors. Since the bridge firmware handles the conversion, this may not matter in practice, but it's worth confirming with hardware if possible.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-31  7:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-30 13:25 [PATCH 0/4] drm/panel: simple: add Waveshare LCD panels Dmitry Baryshkov
2026-03-30 13:25 ` [PATCH 1/4] dt-bindings: display: waveshare,dsp2dpi: describe DSI2LVDS setup Dmitry Baryshkov
2026-03-31  7:17   ` Claude review: " Claude Code Review Bot
2026-03-30 13:25 ` [PATCH 2/4] drm/bridge: waveshare-dsi: support DSI LCD kits with LVDS panels Dmitry Baryshkov
2026-03-31  7:17   ` Claude review: " Claude Code Review Bot
2026-03-30 13:25 ` [PATCH 3/4] dt-bindings: display: panel: add Waveshare LCD panels Dmitry Baryshkov
2026-03-31  7:17   ` Claude review: " Claude Code Review Bot
2026-03-30 13:25 ` [PATCH 4/4] drm/panel: simple: " Dmitry Baryshkov
2026-03-31  7:17   ` Claude Code Review Bot [this message]
2026-03-30 17:21 ` [PATCH 0/4] " Marek Vasut
2026-03-31  1:22   ` Dmitry Baryshkov
2026-03-31  3:11     ` Marek Vasut
2026-03-31  7:17 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-31 15:44 [PATCH v2 0/4] " Dmitry Baryshkov
2026-03-31 15:44 ` [PATCH v2 4/4] " Dmitry Baryshkov
2026-03-31 21:39   ` Claude review: " Claude Code Review Bot
2026-03-31 21:39 ` Claude Code Review Bot
2026-04-12 17:32 [PATCH v3 0/2] " Dmitry Baryshkov
2026-04-13  8:54 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260330-ws-lcd-v1-4-309834a435c0@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox