From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: waveshare-dsi: support DSI LCD kits with LVDS panels
Date: Tue, 31 Mar 2026 17:17:00 +1000 [thread overview]
Message-ID: <review-patch2-20260330-ws-lcd-v1-2-309834a435c0@oss.qualcomm.com> (raw)
In-Reply-To: <20260330-ws-lcd-v1-2-309834a435c0@oss.qualcomm.com>
Patch Review
Clean and minimal change. Uses `i2c_get_match_data()` to retrieve the connector type from match data, which is the correct modern pattern.
```c
ws->bridge.type = (uintptr_t)i2c_get_match_data(i2c);
```
The cast from `void *` via `uintptr_t` to the enum type is the standard pattern used elsewhere in the kernel for storing small integer values in OF match data. This is correct.
```c
{.compatible = "waveshare,dsi2dpi", .data = (void *)DRM_MODE_CONNECTOR_DPI, },
{.compatible = "waveshare,dsi2lvds", .data = (void *)DRM_MODE_CONNECTOR_LVDS, },
```
No issues with this patch.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 7:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 13:25 [PATCH 0/4] drm/panel: simple: add Waveshare LCD panels Dmitry Baryshkov
2026-03-30 13:25 ` [PATCH 1/4] dt-bindings: display: waveshare,dsp2dpi: describe DSI2LVDS setup Dmitry Baryshkov
2026-03-31 7:17 ` Claude review: " Claude Code Review Bot
2026-03-30 13:25 ` [PATCH 2/4] drm/bridge: waveshare-dsi: support DSI LCD kits with LVDS panels Dmitry Baryshkov
2026-03-31 7:17 ` Claude Code Review Bot [this message]
2026-03-30 13:25 ` [PATCH 3/4] dt-bindings: display: panel: add Waveshare LCD panels Dmitry Baryshkov
2026-03-31 7:17 ` Claude review: " Claude Code Review Bot
2026-03-30 13:25 ` [PATCH 4/4] drm/panel: simple: " Dmitry Baryshkov
2026-03-31 7:17 ` Claude review: " Claude Code Review Bot
2026-03-30 17:21 ` [PATCH 0/4] " Marek Vasut
2026-03-31 1:22 ` Dmitry Baryshkov
2026-03-31 3:11 ` Marek Vasut
2026-03-31 7:17 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-31 15:44 [PATCH v2 0/4] " Dmitry Baryshkov
2026-03-31 15:44 ` [PATCH v2 2/4] drm/bridge: waveshare-dsi: support DSI LCD kits with LVDS panels Dmitry Baryshkov
2026-03-31 21:39 ` Claude review: " Claude Code Review Bot
2026-04-12 17:32 [PATCH v3 0/2] drm/panel: simple: add Waveshare LCD panels Dmitry Baryshkov
2026-04-12 17:32 ` [PATCH v3 2/2] drm/bridge: waveshare-dsi: support DSI LCD kits with LVDS panels Dmitry Baryshkov
2026-04-13 8:54 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260330-ws-lcd-v1-2-309834a435c0@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox