public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: waveshare-dsi: support DSI LCD kits with LVDS panels
Date: Mon, 13 Apr 2026 18:54:38 +1000	[thread overview]
Message-ID: <review-patch2-20260412-ws-lcd-v3-2-db22c2631828@oss.qualcomm.com> (raw)
In-Reply-To: <20260412-ws-lcd-v3-2-db22c2631828@oss.qualcomm.com>

Patch Review

Clean driver change. The approach uses `i2c_get_match_data()` to retrieve the connector type from the OF match table, which is the preferred kernel pattern for parameterizing drivers by compatible string.

1. **Match data retrieval**:
```c
-	ws->bridge.type = DRM_MODE_CONNECTOR_DPI;
+	ws->bridge.type = (uintptr_t)i2c_get_match_data(i2c);
```
The `(uintptr_t)` cast from `const void *` is the standard idiom seen throughout the DRM subsystem (e.g., `display-connector.c`, `lvds-codec.c`). `DRM_MODE_CONNECTOR_DPI` is 17 and `DRM_MODE_CONNECTOR_LVDS` is 7 — both non-zero, so there's no ambiguity with NULL. `i2c_get_match_data` will check OF match data, which is correct here since the driver only has an `of_device_id` table (no `i2c_device_id` table with data).

2. **Match table update**:
```c
-	{.compatible = "waveshare,dsi2dpi",},
+	{.compatible = "waveshare,dsi2dpi", .data = (void *)DRM_MODE_CONNECTOR_DPI, },
+	{.compatible = "waveshare,dsi2lvds", .data = (void *)DRM_MODE_CONNECTOR_LVDS, },
```
Correct — maintains backward compatibility for existing `dsi2dpi` DTs while adding the new LVDS variant.

One minor observation: there's no `MODULE_DESCRIPTION` update to mention LVDS (currently says "Waveshare DSI2DPI bridge driver"), but that's cosmetic and not worth holding the patch for.

No functional issues. The series is minimal, correct, and ready to apply.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-13  8:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-12 17:32 [PATCH v3 0/2] drm/panel: simple: add Waveshare LCD panels Dmitry Baryshkov
2026-04-12 17:32 ` [PATCH v3 1/2] dt-bindings: display: waveshare,dsp2dpi: describe DSI2LVDS setup Dmitry Baryshkov
2026-04-13  6:51   ` [PATCH v3 1/2] dt-bindings: display: waveshare, dsp2dpi: " Krzysztof Kozlowski
2026-04-13  8:54   ` Claude review: dt-bindings: display: waveshare,dsp2dpi: " Claude Code Review Bot
2026-04-12 17:32 ` [PATCH v3 2/2] drm/bridge: waveshare-dsi: support DSI LCD kits with LVDS panels Dmitry Baryshkov
2026-04-13  8:54   ` Claude Code Review Bot [this message]
2026-04-13  8:54 ` Claude review: drm/panel: simple: add Waveshare LCD panels Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-31 15:44 [PATCH v2 0/4] " Dmitry Baryshkov
2026-03-31 15:44 ` [PATCH v2 2/4] drm/bridge: waveshare-dsi: support DSI LCD kits with LVDS panels Dmitry Baryshkov
2026-03-31 21:39   ` Claude review: " Claude Code Review Bot
2026-03-30 13:25 [PATCH 0/4] drm/panel: simple: add Waveshare LCD panels Dmitry Baryshkov
2026-03-30 13:25 ` [PATCH 2/4] drm/bridge: waveshare-dsi: support DSI LCD kits with LVDS panels Dmitry Baryshkov
2026-03-31  7:17   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260412-ws-lcd-v3-2-db22c2631828@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox