public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panthor: Use guards for resv locking
Date: Sat, 16 May 2026 11:40:46 +1000	[thread overview]
Message-ID: <review-patch4-20260513-panthor-guard-refactor-v1-4-f2d8c15a97ce@collabora.com> (raw)
In-Reply-To: <20260513-panthor-guard-refactor-v1-4-f2d8c15a97ce@collabora.com>

Patch Review

Clean application of the dma_resv guards from patch 2. Straightforward conversions from `dma_resv_lock()/dma_resv_unlock()` to `guard(dma_resv)`.

**`panthor_gem.c` — `nonblocking_page_setup()` behavior change:**
```c
ACQUIRE(dma_resv_try, resv_guard)(bo->base.resv);
if (ACQUIRE_ERR(dma_resv_try, &resv_guard) || !bo->backing.pages)
    return VM_FAULT_RETRY;
```
The original code checked `dma_resv_trylock()` failure separately from `!bo->backing.pages`. Both returned `VM_FAULT_RETRY`. Combining them is correct and cleaner.

**`panthor_mmu.c` — `panthor_vm_prepare_map_op_ctx()`:**
The final two stanzas become:
```c
guard(dma_resv)(panthor_vm_resv(vm));
drm_gpuvm_bo_extobj_add(op_ctx->map.vm_bo);
...
guard(dma_resv)(bo->base.resv);
guard(mutex)(&bo->base.gpuva.lock);
panthor_gem_update_reclaim_state_locked(bo, NULL);
```
Wait — both `guard(dma_resv)` calls will hold their locks until the end of the function. In the original code, `panthor_vm_resv(vm)` was unlocked before `bo->base.resv` was locked. If `bo->base.resv != panthor_vm_resv(vm)` (which is the condition for entering the `if` block), these are different objects and holding both simultaneously shouldn't deadlock. But this does extend the hold time of the VM resv lock. This is likely fine in practice since the additional work is just a mutex lock and a function call.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  1:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13 16:58 [PATCH 0/6] drm/panthor: Use guards Boris Brezillon
2026-05-13 16:58 ` [PATCH 1/6] drm/panthor: Driver-wide xxx_[un]lock -> [scoped_]guard replacement Boris Brezillon
2026-05-14 13:16   ` Steven Price
2026-05-14 17:09     ` Chia-I Wu
2026-05-16  1:40   ` Claude review: " Claude Code Review Bot
2026-05-13 16:58 ` [PATCH 2/6] dma-resv: Define guards for context-less dma_resv locks Boris Brezillon
2026-05-14 18:23   ` Chia-I Wu
2026-05-16  1:40   ` Claude review: " Claude Code Review Bot
2026-05-13 16:58 ` [PATCH 3/6] drm: Define a conditional guard for drm_dev_{enter,exit}() Boris Brezillon
2026-05-14 18:34   ` [PATCH 3/6] drm: Define a conditional guard for drm_dev_{enter, exit}() Chia-I Wu
2026-05-16  1:40   ` Claude review: drm: Define a conditional guard for drm_dev_{enter,exit}() Claude Code Review Bot
2026-05-13 16:58 ` [PATCH 4/6] drm/panthor: Use guards for resv locking Boris Brezillon
2026-05-14 18:35   ` Chia-I Wu
2026-05-16  1:40   ` Claude Code Review Bot [this message]
2026-05-13 16:58 ` [PATCH 5/6] drm/panthor: Use the drm_dev_access guard Boris Brezillon
2026-05-14 18:36   ` Chia-I Wu
2026-05-16  1:40   ` Claude review: " Claude Code Review Bot
2026-05-13 16:58 ` [PATCH 6/6] drm/panthor: Add a new guard for our custom resume_and_get() PM helper Boris Brezillon
2026-05-14 18:39   ` Chia-I Wu
2026-05-16  1:40   ` Claude review: " Claude Code Review Bot
2026-05-16  1:40 ` Claude review: drm/panthor: Use guards Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260513-panthor-guard-refactor-v1-4-f2d8c15a97ce@collabora.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox