From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panthor: Use guards
Date: Sat, 16 May 2026 11:40:44 +1000 [thread overview]
Message-ID: <review-overall-20260513-panthor-guard-refactor-v1-0-f2d8c15a97ce@collabora.com> (raw)
In-Reply-To: <20260513-panthor-guard-refactor-v1-0-f2d8c15a97ce@collabora.com>
Overall Series Review
Subject: drm/panthor: Use guards
Author: Boris Brezillon <boris.brezillon@collabora.com>
Patches: 14
Reviewed: 2026-05-16T11:40:44.787945
---
This is a well-structured 6-patch series from Boris Brezillon converting panthor's mixture of manual lock/unlock patterns to use the kernel's `guard()`/`scoped_guard()` infrastructure. The series is sensibly ordered: patch 1 handles the bulk mechanical conversion for locks that already have guards, patches 2-3 introduce new guards for `dma_resv` and `drm_dev_{enter,exit}`, and patches 4-6 use those new guards. The overall direction is good — guards eliminate entire classes of lock-leak bugs and the code becomes more readable.
The net diffstat (-712/+589) shows meaningful line reduction. The series has prerequisite patches (a signal-from-irq series) which explains why it doesn't apply cleanly.
I have a few concerns, primarily around patch 6's API signature change and some subtle behavioral differences in the reclaim path (patch 1). Overall quality is high.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-16 1:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 16:58 [PATCH 0/6] drm/panthor: Use guards Boris Brezillon
2026-05-13 16:58 ` [PATCH 1/6] drm/panthor: Driver-wide xxx_[un]lock -> [scoped_]guard replacement Boris Brezillon
2026-05-14 13:16 ` Steven Price
2026-05-14 17:09 ` Chia-I Wu
2026-05-16 1:40 ` Claude review: " Claude Code Review Bot
2026-05-13 16:58 ` [PATCH 2/6] dma-resv: Define guards for context-less dma_resv locks Boris Brezillon
2026-05-14 18:23 ` Chia-I Wu
2026-05-16 1:40 ` Claude review: " Claude Code Review Bot
2026-05-13 16:58 ` [PATCH 3/6] drm: Define a conditional guard for drm_dev_{enter,exit}() Boris Brezillon
2026-05-14 18:34 ` [PATCH 3/6] drm: Define a conditional guard for drm_dev_{enter, exit}() Chia-I Wu
2026-05-16 1:40 ` Claude review: drm: Define a conditional guard for drm_dev_{enter,exit}() Claude Code Review Bot
2026-05-13 16:58 ` [PATCH 4/6] drm/panthor: Use guards for resv locking Boris Brezillon
2026-05-14 18:35 ` Chia-I Wu
2026-05-16 1:40 ` Claude review: " Claude Code Review Bot
2026-05-13 16:58 ` [PATCH 5/6] drm/panthor: Use the drm_dev_access guard Boris Brezillon
2026-05-14 18:36 ` Chia-I Wu
2026-05-16 1:40 ` Claude review: " Claude Code Review Bot
2026-05-13 16:58 ` [PATCH 6/6] drm/panthor: Add a new guard for our custom resume_and_get() PM helper Boris Brezillon
2026-05-14 18:39 ` Chia-I Wu
2026-05-16 1:40 ` Claude review: " Claude Code Review Bot
2026-05-16 1:40 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260513-panthor-guard-refactor-v1-0-f2d8c15a97ce@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox