From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: inno-hdmi: Use the common TMDS char rate constant
Date: Mon, 25 May 2026 22:44:50 +1000 [thread overview]
Message-ID: <review-patch4-20260519144712.1418302-5-javierm@redhat.com> (raw)
In-Reply-To: <20260519144712.1418302-5-javierm@redhat.com>
Patch Review
Removes `#define INNO_HDMI_MIN_TMDS_CLOCK 25000000U` and replaces its single use with `DRM_HDMI_TMDS_CHAR_RATE_MIN`. The old define had a `U` suffix while the new constant does not, but since `mpixelclk` is `unsigned long`, the comparison promotes correctly regardless. The header `<drm/display/drm_hdmi_helper.h>` is already included in this file, so no new `#include` is needed.
**No issues.**
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 12:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 14:46 [PATCH 0/8] drm/display: hdmi: Add common TMDS character rate constants Javier Martinez Canillas
2026-05-19 14:46 ` [PATCH 1/8] " Javier Martinez Canillas
2026-05-19 15:20 ` Jani Nikula
2026-05-20 7:40 ` Javier Martinez Canillas
2026-05-20 7:51 ` Jani Nikula
2026-05-20 8:13 ` Maxime Ripard
2026-05-20 8:36 ` Javier Martinez Canillas
2026-05-20 9:56 ` Dmitry Baryshkov
2026-05-20 12:17 ` Javier Martinez Canillas
2026-05-20 12:58 ` Heiko Stuebner
2026-05-25 12:44 ` Claude review: " Claude Code Review Bot
2026-05-19 14:46 ` [PATCH 2/8] drm/bridge: dw-hdmi: Use the common TMDS char rate constant Javier Martinez Canillas
2026-05-20 12:59 ` Heiko Stuebner
2026-05-20 13:32 ` Neil Armstrong
2026-05-25 12:44 ` Claude review: " Claude Code Review Bot
2026-05-19 14:46 ` [PATCH 3/8] drm/bridge: dw-hdmi-qp: " Javier Martinez Canillas
2026-05-20 13:33 ` Neil Armstrong
2026-05-25 12:44 ` Claude review: " Claude Code Review Bot
2026-05-19 14:47 ` [PATCH 4/8] drm/bridge: inno-hdmi: " Javier Martinez Canillas
2026-05-20 13:00 ` Heiko Stuebner
2026-05-25 12:44 ` Claude Code Review Bot [this message]
2026-05-19 14:47 ` [PATCH 5/8] drm/sti: hdmi: Use the common TMDS char rate constants Javier Martinez Canillas
2026-05-25 12:44 ` Claude review: " Claude Code Review Bot
2026-05-19 14:47 ` [PATCH 6/8] drm/sun4i: hdmi: Use the common TMDS char rate constant Javier Martinez Canillas
2026-05-19 14:57 ` Chen-Yu Tsai
2026-05-25 12:44 ` Claude review: " Claude Code Review Bot
2026-05-19 14:47 ` [PATCH 7/8] drm/msm/hdmi: Use the common TMDS char rate constants in 8996 PHY Javier Martinez Canillas
2026-05-20 9:51 ` Dmitry Baryshkov
2026-05-25 12:44 ` Claude review: " Claude Code Review Bot
2026-05-19 14:47 ` [PATCH 8/8] drm/msm/hdmi: Use the common TMDS char rate constants in 8998 PHY Javier Martinez Canillas
2026-05-20 9:51 ` Dmitry Baryshkov
2026-05-25 12:44 ` Claude review: " Claude Code Review Bot
2026-05-25 12:44 ` Claude review: drm/display: hdmi: Add common TMDS character rate constants Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-20 14:43 [PATCH v2 0/8] " Javier Martinez Canillas
2026-05-20 14:43 ` [PATCH v2 4/8] drm/bridge: inno-hdmi: Use the common TMDS char rate constant Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260519144712.1418302-5-javierm@redhat.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox