From: Javier Martinez Canillas <javierm@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javierm@redhat.com>,
Maxime Ripard <mripard@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Andy Yan <andy.yan@rock-chips.com>,
David Airlie <airlied@gmail.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Jonas Karlman <jonas@kwiboo.se>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>, Simona Vetter <simona@ffwll.ch>,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org
Subject: [PATCH v2 4/8] drm/bridge: inno-hdmi: Use the common TMDS char rate constant
Date: Wed, 20 May 2026 16:43:40 +0200 [thread overview]
Message-ID: <20260520144424.1633354-5-javierm@redhat.com> (raw)
In-Reply-To: <20260520144424.1633354-1-javierm@redhat.com>
Replace the driver local INNO_HDMI_MIN_TMDS_CLOCK define with the shared
constant defined in the <linux/hdmi.h> header.
Suggested-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
---
(no changes since v1)
drivers/gpu/drm/bridge/inno-hdmi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/inno-hdmi.c b/drivers/gpu/drm/bridge/inno-hdmi.c
index 1091af29ad8f..5fa533a4eb34 100644
--- a/drivers/gpu/drm/bridge/inno-hdmi.c
+++ b/drivers/gpu/drm/bridge/inno-hdmi.c
@@ -31,8 +31,6 @@
#include <drm/display/drm_hdmi_helper.h>
#include <drm/display/drm_hdmi_state_helper.h>
-#define INNO_HDMI_MIN_TMDS_CLOCK 25000000U
-
#define DDC_SEGMENT_ADDR 0x30
#define HDMI_SCL_RATE (100 * 1000)
@@ -820,7 +818,7 @@ static enum drm_mode_status inno_hdmi_bridge_mode_valid(struct drm_bridge *bridg
mpixelclk = mode->clock * 1000;
- if (mpixelclk < INNO_HDMI_MIN_TMDS_CLOCK)
+ if (mpixelclk < HDMI_TMDS_CHAR_RATE_MIN_HZ)
return MODE_CLOCK_LOW;
if (inno_hdmi_find_phy_config(hdmi, mpixelclk) < 0)
--
2.54.0
next prev parent reply other threads:[~2026-05-20 14:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 14:43 [PATCH v2 0/8] hdmi: Add common TMDS character rate constants Javier Martinez Canillas
2026-05-20 14:43 ` [PATCH v2 2/8] drm/bridge: dw-hdmi: Use the common TMDS char rate constant Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
2026-05-20 14:43 ` [PATCH v2 3/8] drm/bridge: dw-hdmi-qp: " Javier Martinez Canillas
2026-05-21 8:53 ` Heiko Stuebner
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
2026-05-20 14:43 ` Javier Martinez Canillas [this message]
2026-05-25 11:45 ` Claude review: drm/bridge: inno-hdmi: " Claude Code Review Bot
2026-05-20 14:43 ` [PATCH v2 5/8] drm/sti: hdmi: Use the common TMDS char rate constants Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
2026-05-20 14:43 ` [PATCH v2 6/8] drm/sun4i: hdmi: Use the common TMDS char rate constant Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
2026-05-20 14:43 ` [PATCH v2 7/8] drm/msm/hdmi: Use the common TMDS char rate constants in 8996 PHY Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
2026-05-20 14:43 ` [PATCH v2 8/8] drm/msm/hdmi: Use the common TMDS char rate constants in 8998 PHY Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
[not found] ` <20260520144424.1633354-2-javierm@redhat.com>
2026-05-20 15:01 ` [PATCH v2 1/8] video/hdmi: Add common TMDS character rate constants Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
2026-05-20 16:28 ` [PATCH v2 0/8] hdmi: " Maxime Ripard
2026-05-21 9:59 ` Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260520144424.1633354-5-javierm@redhat.com \
--to=javierm@redhat.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox