From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH v2 1/8] video/hdmi: Add common TMDS character rate constants
Date: Mon, 25 May 2026 21:45:01 +1000 [thread overview]
Message-ID: <review-patch1-87tss215xl.fsf@ocarina.mail-host-address-is-not-set> (raw)
In-Reply-To: <87tss215xl.fsf@ocarina.mail-host-address-is-not-set>
Patch Review
**Not present in the mbox** -- cannot review the actual definitions. This is the most important patch to review since it establishes the naming convention, types, and values that all other patches depend on. From the diffstat (`+6` lines in `include/linux/hdmi.h`), it adds approximately 4 `#define` constants.
Would need to verify: proper `UL` or type suffixes to avoid signed/unsigned issues (the original `INNO_HDMI_MIN_TMDS_CLOCK` used `U` suffix, `HDMI_PCLK_*` used bare int literals).
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 11:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 14:43 [PATCH v2 0/8] hdmi: Add common TMDS character rate constants Javier Martinez Canillas
2026-05-20 14:43 ` [PATCH v2 2/8] drm/bridge: dw-hdmi: Use the common TMDS char rate constant Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
2026-05-20 14:43 ` [PATCH v2 3/8] drm/bridge: dw-hdmi-qp: " Javier Martinez Canillas
2026-05-21 8:53 ` Heiko Stuebner
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
2026-05-20 14:43 ` [PATCH v2 4/8] drm/bridge: inno-hdmi: " Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
2026-05-20 14:43 ` [PATCH v2 5/8] drm/sti: hdmi: Use the common TMDS char rate constants Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
2026-05-20 14:43 ` [PATCH v2 6/8] drm/sun4i: hdmi: Use the common TMDS char rate constant Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
2026-05-20 14:43 ` [PATCH v2 7/8] drm/msm/hdmi: Use the common TMDS char rate constants in 8996 PHY Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
2026-05-20 14:43 ` [PATCH v2 8/8] drm/msm/hdmi: Use the common TMDS char rate constants in 8998 PHY Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
[not found] ` <20260520144424.1633354-2-javierm@redhat.com>
2026-05-20 15:01 ` [PATCH v2 1/8] video/hdmi: Add common TMDS character rate constants Javier Martinez Canillas
2026-05-25 11:45 ` Claude Code Review Bot [this message]
2026-05-20 16:28 ` [PATCH v2 0/8] hdmi: " Maxime Ripard
2026-05-21 9:59 ` Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-87tss215xl.fsf@ocarina.mail-host-address-is-not-set \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox