From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: dw-hdmi: Use the common TMDS char rate constant
Date: Mon, 25 May 2026 21:45:01 +1000 [thread overview]
Message-ID: <review-patch2-20260520144424.1633354-3-javierm@redhat.com> (raw)
In-Reply-To: <20260520144424.1633354-3-javierm@redhat.com>
Patch Review
Straightforward 1:1 replacement of `HDMI14_MAX_TMDSCLK` (340000000) with `HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ` at all 4 usage sites. The commit message correctly notes that 340 MHz was actually HDMI 1.3, not 1.4.
No issues. The `#include <linux/hdmi.h>` is already available in this file.
**Reviewed-by tags:** Heiko Stuebner, Neil Armstrong.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 11:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 14:43 [PATCH v2 0/8] hdmi: Add common TMDS character rate constants Javier Martinez Canillas
2026-05-20 14:43 ` [PATCH v2 2/8] drm/bridge: dw-hdmi: Use the common TMDS char rate constant Javier Martinez Canillas
2026-05-25 11:45 ` Claude Code Review Bot [this message]
2026-05-20 14:43 ` [PATCH v2 3/8] drm/bridge: dw-hdmi-qp: " Javier Martinez Canillas
2026-05-21 8:53 ` Heiko Stuebner
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
2026-05-20 14:43 ` [PATCH v2 4/8] drm/bridge: inno-hdmi: " Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
2026-05-20 14:43 ` [PATCH v2 5/8] drm/sti: hdmi: Use the common TMDS char rate constants Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
2026-05-20 14:43 ` [PATCH v2 6/8] drm/sun4i: hdmi: Use the common TMDS char rate constant Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
2026-05-20 14:43 ` [PATCH v2 7/8] drm/msm/hdmi: Use the common TMDS char rate constants in 8996 PHY Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
2026-05-20 14:43 ` [PATCH v2 8/8] drm/msm/hdmi: Use the common TMDS char rate constants in 8998 PHY Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
[not found] ` <20260520144424.1633354-2-javierm@redhat.com>
2026-05-20 15:01 ` [PATCH v2 1/8] video/hdmi: Add common TMDS character rate constants Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
2026-05-20 16:28 ` [PATCH v2 0/8] hdmi: " Maxime Ripard
2026-05-21 9:59 ` Javier Martinez Canillas
2026-05-25 11:45 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-19 14:46 [PATCH 0/8] drm/display: " Javier Martinez Canillas
2026-05-19 14:46 ` [PATCH 2/8] drm/bridge: dw-hdmi: Use the common TMDS char rate constant Javier Martinez Canillas
2026-05-25 12:44 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260520144424.1633354-3-javierm@redhat.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox