Claude review: hdmi: Add common TMDS character rate constants

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: hdmi: Add common TMDS character rate constants
Author: Javier Martinez Canillas <javierm@redhat.com>
Patches: 12
Reviewed: 2026-05-25T21:45:00.940491

---

This is a clean, well-structured cleanup series that introduces shared TMDS character rate constants in `<linux/hdmi.h>` and replaces per-driver local defines and magic numbers across 7 DRM drivers. The goal is improved readability, correctness (fixing HDMI spec version attributions in naming), and consistency.

**Key observations:**

1. **Patch 1/8 is missing from the mbox.** This is the foundational patch ("video/hdmi: Add common TMDS character rate constants") that adds the constants to `<linux/hdmi.h>`. All other patches depend on it. Without reviewing the actual definitions, I'm inferring the constant values from usage: `HDMI_TMDS_CHAR_RATE_MIN_HZ` = 25 MHz, `HDMI_1_0_TMDS_CHAR_RATE_MAX_HZ` = 165 MHz, `HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ` = 340 MHz, `HDMI_2_0_TMDS_CHAR_RATE_MAX_HZ` = 600 MHz.

2. **The naming convention (`HDMI_$SPEC_TMDS_CHAR_RATE_MAX_HZ`) is clear and follows v2 feedback.** The spec version attribution corrections (e.g., 340 MHz is HDMI 1.3, not 1.4) are accurate.

3. **All numeric replacements are value-correct** -- each constant maps to exactly the same value as the macro/magic number it replaces.

4. **Include dependencies are satisfied** in all drivers, either directly or transitively.

5. **The series is low-risk** -- purely mechanical, no behavioral changes.

The series looks good overall. One minor concern noted below for patches 7 and 8.

---

---
Generated by Claude Code Patch Reviewer