From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: writeback: Modify drm_writeback_signal_completion helper
Date: Mon, 25 May 2026 19:19:15 +1000 [thread overview]
Message-ID: <review-patch4-20260522050313.1800378-5-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20260522050313.1800378-5-suraj.kandpal@intel.com>
Patch Review
Changes `drm_writeback_signal_completion()` to take `struct drm_connector *`.
**Bug:**
In `amdgpu_dm.c`:
```c
- drm_writeback_signal_completion(acrtc->wb_conn, 0);
+ drm_writeback_signal_completion(acrtc->connector, 0);
```
**`acrtc->connector` does not exist.** The field is `acrtc->wb_conn` (type `struct drm_writeback_connector *`). After the API change, this should be:
```c
drm_writeback_signal_completion(drm_writeback_to_connector(acrtc->wb_conn), 0);
```
Notably the MSM driver gets this right in the same patch:
```c
+ drm_writeback_signal_completion(drm_writeback_to_connector(wb_enc->wb_conn), 0);
```
The amdgpu site should follow the same pattern. The `amdgpu_crtc` struct has `struct drm_writeback_connector *wb_conn` (confirmed in `amdgpu_mode.h:513`), so the correct call would use `drm_writeback_to_connector(acrtc->wb_conn)`. Alternatively, the `amdgpu_crtc` struct could be updated to store a `struct drm_connector *` pointer instead, but that's not done in this series.
**This will cause a build failure.**
The `malidp_hw.c` changes are also questionable -- the diff header shows reverting to the original file hash (`9b845d3f34e1`) before the patch 1 changes. This is likely a rebase issue but the final state after applying patches 1 and 4 should be correct (both change the same lines in the same way).
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 9:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 5:03 [PATCH v5 0/7] Refactor drm_writeback_connector structure Suraj Kandpal
2026-05-22 5:03 ` [PATCH v5 1/7] drm: writeback: " Suraj Kandpal
2026-05-25 9:19 ` Claude review: " Claude Code Review Bot
2026-05-22 5:03 ` [PATCH v5 2/7] drm: writeback: Modify writeback init helpers Suraj Kandpal
2026-05-25 9:19 ` Claude review: " Claude Code Review Bot
2026-05-22 5:03 ` [PATCH v5 3/7] drm: writeback: Modify drm_writeback_queue_job helper Suraj Kandpal
2026-05-25 9:19 ` Claude review: " Claude Code Review Bot
2026-05-22 5:03 ` [PATCH v5 4/7] drm: writeback: Modify drm_writeback_signal_completion helper Suraj Kandpal
2026-05-25 9:19 ` Claude Code Review Bot [this message]
2026-05-22 5:03 ` [PATCH v5 5/7] drm: writeback: Modify drm_writeback_get_out_fence helper Suraj Kandpal
2026-05-25 9:19 ` Claude review: " Claude Code Review Bot
2026-05-22 5:03 ` [PATCH v5 6/7] drm: writeback: Modify prepare_writeback_job helper Suraj Kandpal
2026-05-25 9:19 ` Claude review: " Claude Code Review Bot
2026-05-22 5:03 ` [PATCH v5 7/7] drm: writeback: Modify cleanup_writeback_job helper Suraj Kandpal
2026-05-25 9:19 ` Claude review: " Claude Code Review Bot
2026-05-22 5:10 ` [PATCH v5 0/7] Refactor drm_writeback_connector structure Kandpal, Suraj
2026-05-25 9:19 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-21 5:37 [PATCH v4 0/7] " Suraj Kandpal
2026-05-21 5:37 ` [PATCH v4 4/7] drm: writeback: Modify drm_writeback_signal_completion helper Suraj Kandpal
2026-05-25 10:57 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260522050313.1800378-5-suraj.kandpal@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox