From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: writeback: Modify prepare_writeback_job helper
Date: Mon, 25 May 2026 19:19:16 +1000 [thread overview]
Message-ID: <review-patch6-20260522050313.1800378-7-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20260522050313.1800378-7-suraj.kandpal@intel.com>
Patch Review
Changes the `prepare_writeback_job` callback in `struct drm_connector_helper_funcs` from taking `struct drm_writeback_connector *` to `struct drm_connector *`.
**Analysis:** Correct. All driver implementations updated. The rcar-du driver nicely simplifies:
```c
-static int rcar_du_wb_prepare_job(struct drm_writeback_connector *connector,
+static int rcar_du_wb_prepare_job(struct drm_connector *connector,
struct drm_writeback_job *job)
{
- struct drm_connector *conn = drm_writeback_to_connector(connector);
- struct rcar_du_crtc *rcrtc = wb_to_rcar_crtc(conn);
+ struct rcar_du_crtc *rcrtc = wb_to_rcar_crtc(connector);
```
The `drm_writeback_prepare_job()` caller in `drm_writeback.c` is also updated correctly.
Note: in patch 1, `drm_writeback_prepare_job()` was modified to get the connector via `drm_writeback_to_connector()`, and here it passes that connector to the callback. The flow is consistent.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 9:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 5:03 [PATCH v5 0/7] Refactor drm_writeback_connector structure Suraj Kandpal
2026-05-22 5:03 ` [PATCH v5 1/7] drm: writeback: " Suraj Kandpal
2026-05-25 9:19 ` Claude review: " Claude Code Review Bot
2026-05-22 5:03 ` [PATCH v5 2/7] drm: writeback: Modify writeback init helpers Suraj Kandpal
2026-05-25 9:19 ` Claude review: " Claude Code Review Bot
2026-05-22 5:03 ` [PATCH v5 3/7] drm: writeback: Modify drm_writeback_queue_job helper Suraj Kandpal
2026-05-25 9:19 ` Claude review: " Claude Code Review Bot
2026-05-22 5:03 ` [PATCH v5 4/7] drm: writeback: Modify drm_writeback_signal_completion helper Suraj Kandpal
2026-05-25 9:19 ` Claude review: " Claude Code Review Bot
2026-05-22 5:03 ` [PATCH v5 5/7] drm: writeback: Modify drm_writeback_get_out_fence helper Suraj Kandpal
2026-05-25 9:19 ` Claude review: " Claude Code Review Bot
2026-05-22 5:03 ` [PATCH v5 6/7] drm: writeback: Modify prepare_writeback_job helper Suraj Kandpal
2026-05-25 9:19 ` Claude Code Review Bot [this message]
2026-05-22 5:03 ` [PATCH v5 7/7] drm: writeback: Modify cleanup_writeback_job helper Suraj Kandpal
2026-05-25 9:19 ` Claude review: " Claude Code Review Bot
2026-05-22 5:10 ` [PATCH v5 0/7] Refactor drm_writeback_connector structure Kandpal, Suraj
2026-05-25 9:19 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-21 5:37 [PATCH v4 0/7] " Suraj Kandpal
2026-05-21 5:37 ` [PATCH v4 6/7] drm: writeback: Modify prepare_writeback_job helper Suraj Kandpal
2026-05-25 10:57 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch6-20260522050313.1800378-7-suraj.kandpal@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox