public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu/buddy: Track per-order free blocks with a scoreboard
Date: Mon, 25 May 2026 19:06:38 +1000	[thread overview]
Message-ID: <review-patch4-20260522092600.32818-5-francois.dugast@intel.com> (raw)
In-Reply-To: <20260522092600.32818-5-francois.dugast@intel.com>

Patch Review

**Correctness: The scoreboard maintenance looks correct.**

The increment/decrement sites are:

1. `mark_free()` — increment (block enters free state)
2. `mark_allocated()` — decrement (block leaves free state)
3. `mark_split()` — decrement (block leaves free state)
4. `__gpu_buddy_free()` coalescing loop — decrement for buddy being removed from tree
5. `__force_merge()` — decrement for block being removed from tree
6. `__gpu_buddy_undo_splits()` — decrement for block being removed from tree

These cover all the places where `rbtree_remove` is called on a free block (decrements) and where `rbtree_insert` is called on a free block (increments, via `mark_free`).

**Initialization and cleanup look correct** — `kcalloc` zeroes the array, `kfree` in both the init error path and `fini`.

**One minor note on the print threshold change:**

```c
-		if (free < SZ_1M)
+		if (free < SZ_1M)
```

In this patch the threshold is still based on `free` (the total free bytes). This gets changed to `block_size` in patch 5. That's fine — incremental development.

No issues.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25  9:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22  9:25 [PATCH v4 0/5] gpu/buddy: Per-order free and used block scoreboards Francois Dugast
2026-05-22  9:25 ` [PATCH v4 1/5] gpu/buddy: Fix use-after-free in split_block() call sites Francois Dugast
2026-05-25  9:06   ` Claude review: " Claude Code Review Bot
2026-05-22  9:25 ` [PATCH v4 2/5] gpu/buddy: Remove redundant condition in alloc_from_freetree() error path Francois Dugast
2026-05-22 10:10   ` Matthew Auld
2026-05-25  9:06   ` Claude review: " Claude Code Review Bot
2026-05-22  9:25 ` [PATCH v4 3/5] gpu/buddy: Introduce __gpu_buddy_undo_splits() helper Francois Dugast
2026-05-25  9:06   ` Claude review: " Claude Code Review Bot
2026-05-22  9:25 ` [PATCH v4 4/5] gpu/buddy: Track per-order free blocks with a scoreboard Francois Dugast
2026-05-25  9:06   ` Claude Code Review Bot [this message]
2026-05-22  9:25 ` [PATCH v4 5/5] gpu/buddy: Track per-order used " Francois Dugast
2026-05-22 10:25   ` Arunpravin Paneer Selvam
2026-05-22 10:56     ` Matthew Auld
2026-05-25  9:06   ` Claude review: " Claude Code Review Bot
2026-05-25  9:06 ` Claude review: gpu/buddy: Per-order free and used block scoreboards Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-11 16:41 [PATCH v2 0/3] " Francois Dugast
2026-05-11 16:41 ` [PATCH v2 2/3] gpu/buddy: Track per-order free blocks with a scoreboard Francois Dugast
2026-05-16  4:58   ` Claude review: " Claude Code Review Bot
2026-05-04 13:52 [PATCH 0/2] gpu/buddy: Per-order free and used block scoreboards Francois Dugast
2026-05-04 13:52 ` [PATCH 1/2] gpu/buddy: Track per-order free blocks with a scoreboard Francois Dugast
2026-05-04 22:19   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260522092600.32818-5-francois.dugast@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox