From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu/buddy: Remove redundant condition in alloc_from_freetree() error path
Date: Mon, 25 May 2026 19:06:37 +1000 [thread overview]
Message-ID: <review-patch2-20260522092600.32818-3-francois.dugast@intel.com> (raw)
In-Reply-To: <20260522092600.32818-3-francois.dugast@intel.com>
Patch Review
**Correctness: Correct cleanup.**
The `err_undo` label is only reachable from inside the `while (tmp != order)` loop (via `goto err_undo` at line 842). At that point `tmp` is guaranteed to differ from `order` — if they were equal, the loop wouldn't have been entered. Removing the guard is safe.
```c
err_undo:
rbtree_remove(mm, block);
__gpu_buddy_free(mm, block, false);
```
This is a straightforward simplification. No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 9:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 9:25 [PATCH v4 0/5] gpu/buddy: Per-order free and used block scoreboards Francois Dugast
2026-05-22 9:25 ` [PATCH v4 1/5] gpu/buddy: Fix use-after-free in split_block() call sites Francois Dugast
2026-05-25 9:06 ` Claude review: " Claude Code Review Bot
2026-05-22 9:25 ` [PATCH v4 2/5] gpu/buddy: Remove redundant condition in alloc_from_freetree() error path Francois Dugast
2026-05-22 10:10 ` Matthew Auld
2026-05-25 9:06 ` Claude Code Review Bot [this message]
2026-05-22 9:25 ` [PATCH v4 3/5] gpu/buddy: Introduce __gpu_buddy_undo_splits() helper Francois Dugast
2026-05-25 9:06 ` Claude review: " Claude Code Review Bot
2026-05-22 9:25 ` [PATCH v4 4/5] gpu/buddy: Track per-order free blocks with a scoreboard Francois Dugast
2026-05-25 9:06 ` Claude review: " Claude Code Review Bot
2026-05-22 9:25 ` [PATCH v4 5/5] gpu/buddy: Track per-order used " Francois Dugast
2026-05-22 10:25 ` Arunpravin Paneer Selvam
2026-05-22 10:56 ` Matthew Auld
2026-05-25 9:06 ` Claude review: " Claude Code Review Bot
2026-05-25 9:06 ` Claude review: gpu/buddy: Per-order free and used block scoreboards Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260522092600.32818-3-francois.dugast@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox