From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/xe/hw_error: Use HW_ERR prefix in log
Date: Mon, 25 May 2026 17:57:41 +1000 [thread overview]
Message-ID: <review-patch4-20260523050212.557292-5-raag.jadav@intel.com> (raw)
In-Reply-To: <20260523050212.557292-5-raag.jadav@intel.com>
Patch Review
**Verdict: Correct change, questionable Fixes tag.**
The change itself is straightforward and correct — `HW_ERR` is defined in `include/linux/printk.h` as `"[Hardware Error]: "` and is the standard kernel convention for hardware error reporting. The string concatenation with the format literal is fine:
```c
drm_warn(&xe->drm, HW_ERR "%s %s detected\n", name, severity_str);
```
**On the Fixes tag:** The referenced commit `01aab7e1c9d4` ("drm/xe/xe_hw_error: Add support for PVC SoC errors") simply didn't use the `HW_ERR` prefix. Missing a log prefix isn't a functional bug — this is a convention/consistency improvement. It might be more appropriate without a `Fixes:` tag, or at least should not be backported to stable trees.
**Pre-existing issue (not introduced by this patch):** The `log_soc_error` messages are missing a trailing `\n`:
```c
drm_warn(&xe->drm, HW_ERR "%s SOC %s detected", name, severity_str);
```
Compare with `log_hw_error` and `log_gt_err`, which both have `\n`. This inconsistency predates this patch but could be worth fixing in a follow-up.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 7:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 5:00 [PATCH v2 0/4] DRM RAS Fixes Raag Jadav
2026-05-23 5:00 ` [PATCH v2 1/4] drm/ras: Cancel and free message on get counter failure Raag Jadav
2026-05-25 7:57 ` Claude review: " Claude Code Review Bot
2026-05-23 5:00 ` [PATCH v2 2/4] drm/xe/drm_ras: Make counter allocation drm managed Raag Jadav
2026-05-25 7:57 ` Claude review: " Claude Code Review Bot
2026-05-23 5:00 ` [PATCH v2 3/4] drm/xe/drm_ras: Add per node cleanup action Raag Jadav
2026-05-25 7:57 ` Claude review: " Claude Code Review Bot
2026-05-23 5:00 ` [PATCH v2 4/4] drm/xe/hw_error: Use HW_ERR prefix in log Raag Jadav
2026-05-25 7:57 ` Claude Code Review Bot [this message]
2026-05-25 7:57 ` Claude review: DRM RAS Fixes Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260523050212.557292-5-raag.jadav@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox