From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: vfio/pci: Convert BAR mmap() to use a DMABUF
Date: Thu, 28 May 2026 12:28:52 +1000 [thread overview]
Message-ID: <review-patch4-20260527102319.100128-5-mattev@meta.com> (raw)
In-Reply-To: <20260527102319.100128-5-mattev@meta.com>
Patch Review
The main conversion patch. Removes `vma_to_pfn()`, updates the fault handler, and makes `VFIO_PCI_CORE` depend on `DMA_SHARED_BUFFER` and `PCI_P2PDMA_CORE`.
**Kconfig change**:
```c
+ select PCI_P2PDMA_CORE
+ select DMA_SHARED_BUFFER
```
Making these unconditional `select`s for `VFIO_PCI_CORE` is a significant dependency change. `DMA_SHARED_BUFFER` is generally available, but this should be called out in the commit message more prominently since it affects all VFIO PCI users.
**Conditional `.attach` in dma_buf_ops**:
```c
static const struct dma_buf_ops vfio_pci_dmabuf_ops = {
+#ifdef CONFIG_VFIO_PCI_DMABUF
.attach = vfio_pci_dma_buf_attach,
+#endif
```
Setting `.attach = NULL` when `CONFIG_VFIO_PCI_DMABUF` is disabled means DMA-BUF attach will silently succeed (the core code skips the callback if NULL). This is intentional -- BAR mmap DMABUFs don't need P2P attach semantics -- but it's worth noting that this means the DMABUFs created on the mmap path can't be used for DMA by importers when P2P is disabled.
**Default fault return changed**: The old code defaulted to `VM_FAULT_FALLBACK`; the new code defaults to `VM_FAULT_SIGBUS`. This is correct since a revoked buffer should SIGBUS, and the fallback case is now explicit in the `-EAGAIN` return from `find_pfn`.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-28 2:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 10:23 [PATCH v2 0/9] vfio/pci: Add mmap() for DMABUFs Matt Evans
2026-05-27 10:23 ` [PATCH v2 1/9] PCI/P2PDMA: Add CONFIG_PCI_P2PDMA_CORE Matt Evans
2026-05-27 16:07 ` Logan Gunthorpe
2026-05-27 17:13 ` Matt Evans
2026-05-27 21:09 ` Alex Williamson
2026-05-28 2:28 ` Claude review: " Claude Code Review Bot
2026-05-27 10:23 ` [PATCH v2 2/9] vfio/pci: Add a helper to look up PFNs for DMABUFs Matt Evans
2026-05-27 22:38 ` Alex Williamson
2026-05-28 2:28 ` Claude review: " Claude Code Review Bot
2026-05-27 10:23 ` [PATCH v2 3/9] vfio/pci: Add a helper to create a DMABUF for a BAR-map VMA Matt Evans
2026-05-27 22:59 ` Alex Williamson
2026-05-28 2:28 ` Claude review: " Claude Code Review Bot
2026-05-27 10:23 ` [PATCH v2 4/9] vfio/pci: Convert BAR mmap() to use a DMABUF Matt Evans
2026-05-28 2:28 ` Claude Code Review Bot [this message]
2026-05-27 10:23 ` [PATCH v2 5/9] vfio/pci: Provide a user-facing name for BAR mappings Matt Evans
2026-05-28 2:28 ` Claude review: " Claude Code Review Bot
2026-05-27 10:23 ` [PATCH v2 6/9] vfio/pci: Clean up BAR zap and revocation Matt Evans
2026-05-28 2:28 ` Claude review: " Claude Code Review Bot
2026-05-27 10:23 ` [PATCH v2 7/9] vfio/pci: Support mmap() of a VFIO DMABUF Matt Evans
2026-05-28 2:28 ` Claude review: " Claude Code Review Bot
2026-05-27 10:23 ` [PATCH v2 8/9] vfio/pci: Permanently revoke a DMABUF on request Matt Evans
2026-05-28 2:28 ` Claude review: " Claude Code Review Bot
2026-05-27 10:23 ` [PATCH v2 9/9] vfio/pci: Add mmap() attributes to DMABUF feature Matt Evans
2026-05-28 2:28 ` Claude review: " Claude Code Review Bot
2026-05-28 2:28 ` Claude review: vfio/pci: Add mmap() for DMABUFs Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260527102319.100128-5-mattev@meta.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox