public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: vfio/pci: Provide a user-facing name for BAR mappings
Date: Thu, 28 May 2026 12:28:53 +1000	[thread overview]
Message-ID: <review-patch5-20260527102319.100128-6-mattev@meta.com> (raw)
In-Reply-To: <20260527102319.100128-6-mattev@meta.com>

Patch Review

Nice quality-of-life patch for debugging. Generates names like `vfio1234567890:ffff:ff:3f.7/5`.

**Direct access to `priv->dmabuf->name_lock`**:
```c
+	spin_lock(&priv->dmabuf->name_lock);
+	kfree(priv->dmabuf->name);
+	priv->dmabuf->name = bufname;
+	spin_unlock(&priv->dmabuf->name_lock);
```
This directly reaches into `struct dma_buf` internals rather than using the `DMA_BUF_SET_NAME` path. While functionally fine (and avoids an unnecessary `copy_from_user`), it's fragile if the dma-buf subsystem changes its internal locking. Consider using `dma_buf_set_name()` if one exists, or at minimum add a comment explaining why direct access is used.

**`#include <uapi/linux/dma-buf.h>`**: Kernel code should include `<linux/dma-buf.h>` rather than the UAPI header. The UAPI header is pulled for `DMA_BUF_NAME_LEN`, which should be available through the normal header.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-28  2:28 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27 10:23 [PATCH v2 0/9] vfio/pci: Add mmap() for DMABUFs Matt Evans
2026-05-27 10:23 ` [PATCH v2 1/9] PCI/P2PDMA: Add CONFIG_PCI_P2PDMA_CORE Matt Evans
2026-05-27 16:07   ` Logan Gunthorpe
2026-05-27 17:13     ` Matt Evans
2026-05-27 21:09   ` Alex Williamson
2026-05-28  2:28   ` Claude review: " Claude Code Review Bot
2026-05-27 10:23 ` [PATCH v2 2/9] vfio/pci: Add a helper to look up PFNs for DMABUFs Matt Evans
2026-05-27 22:38   ` Alex Williamson
2026-05-28  2:28   ` Claude review: " Claude Code Review Bot
2026-05-27 10:23 ` [PATCH v2 3/9] vfio/pci: Add a helper to create a DMABUF for a BAR-map VMA Matt Evans
2026-05-27 22:59   ` Alex Williamson
2026-05-28  2:28   ` Claude review: " Claude Code Review Bot
2026-05-27 10:23 ` [PATCH v2 4/9] vfio/pci: Convert BAR mmap() to use a DMABUF Matt Evans
2026-05-28  2:28   ` Claude review: " Claude Code Review Bot
2026-05-27 10:23 ` [PATCH v2 5/9] vfio/pci: Provide a user-facing name for BAR mappings Matt Evans
2026-05-28  2:28   ` Claude Code Review Bot [this message]
2026-05-27 10:23 ` [PATCH v2 6/9] vfio/pci: Clean up BAR zap and revocation Matt Evans
2026-05-28  2:28   ` Claude review: " Claude Code Review Bot
2026-05-27 10:23 ` [PATCH v2 7/9] vfio/pci: Support mmap() of a VFIO DMABUF Matt Evans
2026-05-28  2:28   ` Claude review: " Claude Code Review Bot
2026-05-27 10:23 ` [PATCH v2 8/9] vfio/pci: Permanently revoke a DMABUF on request Matt Evans
2026-05-28  2:28   ` Claude review: " Claude Code Review Bot
2026-05-27 10:23 ` [PATCH v2 9/9] vfio/pci: Add mmap() attributes to DMABUF feature Matt Evans
2026-05-28  2:28   ` Claude review: " Claude Code Review Bot
2026-05-28  2:28 ` Claude review: vfio/pci: Add mmap() for DMABUFs Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch5-20260527102319.100128-6-mattev@meta.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox