public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/v3d: Reduce PM runtime autosuspend delay
Date: Thu, 04 Jun 2026 15:23:15 +1000	[thread overview]
Message-ID: <review-patch4-20260530-v3d-fix-rpi4-freezes-v1-4-c2c8307da6ce@igalia.com> (raw)
In-Reply-To: <20260530-v3d-fix-rpi4-freezes-v1-4-c2c8307da6ce@igalia.com>

Patch Review

**Purpose:** With the cache/MMU bugs fixed, the inflated 100ms autosuspend delay is no longer needed. Reduce to 50ms.

**Code change in `v3d_drv.c:423`:**
```c
pm_runtime_set_autosuspend_delay(dev, 50);
```

**Analysis:**
- The rationale is well explained in the commit message: 100ms was a workaround for the bugs fixed in patches 1-3.
- This patch has no `Fixes:` tag, which is correct — it's a tuning change, not a bugfix.
- No `Cc: stable@` either, which is correct — this should not be backported independently of the series.

**Question:** Is 50ms the right value? The commit message says "a more reasonable value" but doesn't cite benchmarks or power measurements. For a desktop/embedded system like RPi4, the difference between 50ms and 100ms is unlikely to matter for power savings but could theoretically increase suspend/resume cycle frequency. This is a judgment call for the maintainers — the value seems reasonable, but some data or a reference to what other GPU drivers use would strengthen the justification. Not a blocker.

**Verdict: Fine as-is; the maintainers can adjust the value at merge time if they prefer a different number.**

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-06-04  5:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-30 18:37 [PATCH 0/4] drm/v3d: Fix RPi 4 system hangs from stale cache and MMU state Maíra Canal
2026-05-30 18:37 ` [PATCH 1/4] drm/v3d: Wait for pending L2T flush before cleaning caches Maíra Canal
2026-06-04  5:23   ` Claude review: " Claude Code Review Bot
2026-05-30 18:37 ` [PATCH 2/4] drm/v3d: Flush MMU TLB and cache during runtime resume Maíra Canal
2026-06-04  5:23   ` Claude review: " Claude Code Review Bot
2026-05-30 18:37 ` [PATCH 3/4] drm/v3d: Clean caches before runtime suspend Maíra Canal
2026-06-04  5:23   ` Claude review: " Claude Code Review Bot
2026-05-30 18:37 ` [PATCH 4/4] drm/v3d: Reduce PM runtime autosuspend delay Maíra Canal
2026-06-04  5:23   ` Claude Code Review Bot [this message]
2026-06-04  5:23 ` Claude review: drm/v3d: Fix RPi 4 system hangs from stale cache and MMU state Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260530-v3d-fix-rpi4-freezes-v1-4-c2c8307da6ce@igalia.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox